Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plaintext for SignedData value in RAMF messages should start with message type OID #70

Open
gnarea opened this issue Aug 6, 2020 · 0 comments
Labels
attribute-security A (potential) security threat enhancement New feature or request

Comments

@gnarea
Copy link
Member

gnarea commented Aug 6, 2020

Each RAMF message type should be assigned an OID and that OID should be the first item in the sequence that gets signed. This would prevent against an attack where the type of a RAMF message is changed.

I believe the probability and impact are both low. In fact, I don't think this attack can work with the current RAMF messages being as all payloads are very different to each other, but this is a good practice and we might have future RAMF messages with compatible payloads.

@gnarea gnarea added bug Something isn't working attribute-security A (potential) security threat enhancement New feature or request and removed bug Something isn't working labels Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attribute-security A (potential) security threat enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant