Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Day/night themes #534

Open
baka-kaba opened this issue Oct 6, 2017 · 0 comments
Open

Day/night themes #534

baka-kaba opened this issue Oct 6, 2017 · 0 comments

Comments

@baka-kaba
Copy link
Contributor

Add the option for an alternative theme, that's applied when the system says it's "night"

AppCompat has some automated functionality for this, but it's tied to extending a theme that automatically goes light or dark, which isn't how our themes work.

Since our theme system has a basic API that takes a forum and internally decides what theme to return, it shouldn't be too hard to add some extra logic. If the system decides to supply the current user-selected theme, it just needs to provide the 'dark theme' if there's one set/enabled in the preferences, and it's currently 'night'. Activities and the WebView both hook into this system, so it should just work once it's returning the correct theme

We just need to be able to get the current day/night status from the system

@Sereri Sereri added this to To Do in Awful.apk Improvements Dec 30, 2017
@Sereri Sereri added this to the Awful 4.0 milestone Dec 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants