You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This library uses log.Fatal() in some codes despite that causes exit the program when failed to connect for OANDA API.
So, I want to suggest the error return to the caller instead of use log.Fatal().
Of cause, my suggestion has a big impact on the Interfaces of this library. Therefore I hope someone will come up with a good idea more than my suggestion.
Thank you for this great library,
Osamu
The text was updated successfully, but these errors were encountered:
I originally forked this project for this reason, and intended on creating a PR with changes to error handling, but I ended up making far more changes than I anticipated and so didn't make the PR. I don't think I'm going to maintain my fork any more as I'm no longer using it but I'd be happy to revert my more extreme changes and see what you think about maybe merging it @AwolDes
@stewi1014 more than happy for you to put up a PR with any changes you've made. I haven't worked on this for awhile, but I'm glad people are finding it useful and forking the project 💯
Hi there,
This library uses log.Fatal() in some codes despite that causes exit the program when failed to connect for OANDA API.
So, I want to suggest the error return to the caller instead of use log.Fatal().
Of cause, my suggestion has a big impact on the Interfaces of this library. Therefore I hope someone will come up with a good idea more than my suggestion.
Thank you for this great library,
Osamu
The text was updated successfully, but these errors were encountered: