Add controls window #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ax9D
requested changes
Nov 17, 2021
| ui.label("Pan the graph"); | ||
| ui.end_row(); | ||
|
|
||
| ui.label("ctrl"); |
There was a problem hiding this comment.
Minor nitpick, but can you please change "ctrl" to "Ctrl", to be consistent with the rest of the code.
There was a problem hiding this comment.
Since you merged this already I added the change in #4
There was a problem hiding this comment.
I didn't want to make a whole pr just for a typo so I bundled it up with a cargo fmt and a clippy lint, I hope that's okay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I noticed there is nowhere in the app where you can see the controls, and even though they are simple enough I thought it might be nice to have them somewhere.
Only caveat is that if you add more controls then you'll have to remember to update this window too