Miscellaneous formatting and style changes #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ax9D
reviewed
Nov 18, 2021
Ax9D
reviewed
Nov 18, 2021
|
Why was this closed? |
|
I assumed undoing those changes was too much work to ask for, as I misinterpreted what "resolve" meant, I apologise for not understanding the intent, I'm still fairly new to (and learning) the semantics around Pull Requests on GitHub, I am reopening the PR, extremely sorry about the inconvenience. |
|
No worries. Changes have already been undone, so should be good to merge. |
|
Merged, thank you for your efforts! , and dealing with my ineptitude... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the low-hanging fruit PR. Went through and cleaned up formatting and some small code layout issues. No major business logic changes. Moved
Node,Link, andPortdefinitions intograph.rsafter pruning some unnecessary methods (like field getters). Didn't touch the topological sort implementation.