Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

max_duration ignored in find_peaks #188

Closed
JelleAalbers opened this issue Jun 9, 2019 · 1 comment
Closed

max_duration ignored in find_peaks #188

JelleAalbers opened this issue Jun 9, 2019 · 1 comment

Comments

@JelleAalbers
Copy link
Member

We should either change find_peaks to account for it, or remove the argument.
JelleAalbers added a commit to JelleAalbers/strax that referenced this issue Jun 15, 2019
@JelleAalbers
Remove max_duration, move find_peak_groups from straxen
06d6c36 
closes AxFoundation#188
@JelleAalbers
Copy link
Member Author

I removed max_duration. We can add support for it when we find out we need it.

@JelleAalbers JelleAalbers mentioned this issue Mar 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JelleAalbers