Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give plugins the option to use start and end in compute #239

Closed
JelleAalbers opened this issue Mar 5, 2020 · 0 comments
Closed

Give plugins the option to use start and end in compute #239

JelleAalbers opened this issue Mar 5, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@JelleAalbers
Copy link
Member

Currently you have to override do_compute to do this. We can use inspection, as for compute_takes_chunk_i, to figure out if these arguments need to be passed.
@JelleAalbers JelleAalbers added the enhancement New feature or request label Mar 5, 2020
JelleAalbers added a commit to XENONnT/straxen that referenced this issue Mar 5, 2020
@JelleAalbers
Fix (sort of) pulse counting for empty chunks
eb7e567 
Previously we returned a result with time = 0, which crashes the processing. Now we return nothing. We should instead return a row with proper timing and zeros for the counts, but this requires AxFoundation/strax#239
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JelleAalbers