Fix bug in rref() function #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove Dual, HyperDual & Number * Implements all of (Axect#22)
* Update default numerical integration in prelude * Integrate threading feature in matrixmultiply
* Fix a bug in `quantile`
* Implement Cholesky Decomposition (Axect#46) * Add `is_symmetric` method to Matrix
* Implement Cholesky Decomposition (Axect#48) * Add `is_symmetric` method to Matrix
* Add methods to control `lambda` in LM method (Axect#49)
* Weighted Uniform * PRS
* Update `puruspe` to `0.2.0`
* Implement Cubic Hermite Spline * Changes in `CubicSpline` * Changes in `Calculus`
Fix bug in linspace and logspace
|
@thettasch You are absolutely right! Thank you for great work! 👍 |
|
I release |
Axect
added
good first issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an error in the function to find the reduced row echelon form of a matrix. This error causes the function to panic for certain matricies.
The pseudocode at (https://rosettacode.org/wiki/Reduced_row_echelon_form) shows that if columnCount == lead, the function should stop. The old implementation used a break statement, which only broke out of the while loop at line 3310, where it should break out of the main for loop at line 3305. This is easily fixed by using named loops to break out of a specific loop.