Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two copies of TFT? #86

Open
marcharper opened this issue Apr 22, 2020 · 3 comments
Open

Two copies of TFT? #86

marcharper opened this issue Apr 22, 2020 · 3 comments

Comments

@marcharper
Copy link
Member

Both k92r and ktitfortatc point to axl.TitForTat. Is there a reason that we include both? This means that all_strategies will have two copies of TFT. Just checking that this is intentional.

@drvinceknight
Copy link
Member

If I recall correctly all_strategies is just all the strategies in the Fortran collection and then we have https://github.com/Axelrod-Python/axelrod-fortran/blob/master/src/axelrod_fortran/strategies.py#L354 which is second_tournament_strategies and that's the strategies used in the second tournament (so there's only 1 TfT there).

This is how I ran the revisiting code.

@meatballs
Copy link
Member

The TourExec code that we have was actually the code used to test the strategies for the second tournament rather than the tournament itself. Here's a snippet of the first two lines:

    Program AxTest
c   For  testings of PD tour program.

The 'named' strategies, such as ktitfortat, were part of the testing.

We chose to incorporate all the strategies we could see at the time. (To start with, we didn't even know that K92R was TitForTat).

@marcharper
Copy link
Member Author

I see, thanks. Perhaps we should explain this in the readme? I.e this is the test code, if you want to rerun the second tournament use second_tournament_strategies, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants