Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed change to how config works #175

Closed
2 tasks done
kingsleyh opened this issue May 10, 2018 · 1 comment
Closed
2 tasks done

Proposed change to how config works #175

kingsleyh opened this issue May 10, 2018 · 1 comment
Assignees

Comments

@kingsleyh
Copy link
Contributor

kingsleyh commented May 10, 2018

Checklist

  • You've tried latest version of SushiChain
  • You've confirmed there is not a same sugestion

Description

Currently to use config - you set up a default configuration and you can run any of the binaries and it picks up that config and you can override it with the command line as well.

I think an extra thing that would make it more awesome is this:

instead of:

sushi config use --name=local_sushid
sushid
sushi config use --name=local_miner
sushim
sushi config use --name=local_wallet
sushi wt amount

it would be nice to just override the whole config:

sushid --config=local_sushid
sushim --config=local_miner
sushi wt amount --config=local_wallet

but still get to do this (which is generally useful shortcut for day to day):

sushi config use --config=remote_wallet1
sushi wt amount

I'm happy to make a PR that explores this

@kingsleyh kingsleyh self-assigned this May 10, 2018
@tbrand
Copy link
Contributor

tbrand commented May 12, 2018

Agree

@kingsleyh kingsleyh mentioned this issue May 18, 2018
1 task
@tbrand tbrand closed this as completed May 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants