Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ER - Retina icons #449

Closed
alexrollin opened this issue Sep 5, 2018 · 6 comments
Closed

ER - Retina icons #449

alexrollin opened this issue Sep 5, 2018 · 6 comments

Comments

@alexrollin
Copy link
Contributor

Allow retina icons (optional, secondary?)
Now possible with 3.8+ default is optimized=true

https://stackoverflow.com/questions/9208916/google-map-custom-markers-retina-resolution

reported here:
https://wpgeodirectory.com/support/topic/changing-the-image-size-that-is-seen-on-the-map-2/#post-445384

@Stiofan
Copy link
Contributor

Stiofan commented Jan 14, 2020

Optimized=true is not an option we can use, it causes issues with lots of markers.

We can use https://developers.google.com/maps/documentation/javascript/reference/marker#Icon.scaledSize

@kprajapatii i think our options are either add a second input for retina or ask for 2x image.
what do u think?

@alexrollin
Copy link
Contributor Author

fwiw I recommend a second input if only for the sake of variety

@Stiofan
Copy link
Contributor

Stiofan commented Jan 14, 2020

Its not something we really want to "vary"... mo options, mo problems

@kprajapatii
Copy link
Contributor

To use Icon.scaledSize option which size will be perfect? Is it fixed size or calculated from icon size dimensions?

@Stiofan
Copy link
Contributor

Stiofan commented Jan 16, 2020

You need to set a specific size. So, maybe the way to do it is if the height is above a certain size then we devide it in half? We already provide the icon sizes in the api response, so either we set a flag r=true (rentina=true) or we just do if height>30px devide height and width in half and pass that to Icon.scaledSize. thoughts?

@kprajapatii
Copy link
Contributor

Fixed

See 1882471

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants