Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the photo--editor folder in the repo #243

Merged
merged 3 commits into from Jul 18, 2021
Merged

Adding the photo--editor folder in the repo #243

merged 3 commits into from Jul 18, 2021

Conversation

soma2000-lang
Copy link
Contributor

Description

photo --editor is a Photo editor where one can flip(both horizontally and vertically),resize ,gray scale images

Checklist

  • I've been assigned an issue related to this PR.
  • I've used beautifiers.
  • I've made a README.md file for my Project.
  • The README.md file of my projrct contains Project title, Description, Use of project, Set up, Stack used and Output (Screenshots).

Related Issues or Pull Requests number

#230

@soma2000-lang
Copy link
Contributor Author

@chicken-biryani Please look into this pr

Copy link
Collaborator

@harshita2216 harshita2216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your readme file should have the following details -

  1. Introduction
  2. Use of the project
  3. Steps to use it locally
  4. Screenshots (your screenshots doesn't seem to work)

Also, please add your project details to index.md file.

Copy link
Collaborator

@harshita2216 harshita2216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Tech stack also! @soma2000-lang

@harshita2216
Copy link
Collaborator

Your readme file should have the following details -

  1. Introduction
  2. Use of the project
  3. Steps to use it locally
  4. Screenshots (your screenshots doesn't seem to work)

Also, please add your project details to index.md file.

I've asked you to add your project details to index.md file as well. Please do that! Thanks.

@soma2000-lang
Copy link
Contributor Author

soma2000-lang commented Jul 17, 2021

@harshita2216 @chicken-biryani I have made the required changes
Can u plz merge now

@harshita2216
Copy link
Collaborator

@harshita2216 @chicken-biryani I have made the required changes
Can u plz merge now

I will merge it tomorrow after I resolve the conflicts. Don't worry!

@soma2000-lang
Copy link
Contributor Author

Okay thanks

@harshita2216 harshita2216 added the 🟥 Level4 This issue will be considered as level 4 issue for LGM-SOC 21.Points will be 45. label Jul 17, 2021
@harshita2216
Copy link
Collaborator

harshita2216 commented Jul 17, 2021

Okay thanks

It is difficult to resolve conflicts on the phone, hence I have only approved it for now.
It will be merging it tomorrow morning positively. :)

@harshita2216 harshita2216 merged commit 0780a76 into Ayushparikh-code:main Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟥 Level4 This issue will be considered as level 4 issue for LGM-SOC 21.Points will be 45.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Photo Editor in html,css and javascript
3 participants