Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring font-awesome.css in-package #19

Open
ocdtrekkie opened this issue May 17, 2016 · 1 comment
Open

Bring font-awesome.css in-package #19

ocdtrekkie opened this issue May 17, 2016 · 1 comment

Comments

@ocdtrekkie
Copy link

Privacy Badger detects one outside call in your app to netdna.bootstrapcdn.com, which seems to be for font-awesome.css, which really should be inside the app package and not brought in from an outside source. Note that while this works right now, eventually client-side sandboxing in Sandstorm will break this existing setup.

@ocdtrekkie
Copy link
Author

Allegedly the official fontawesome package, at https://atmospherejs.com/fortawesome/fontawesome should be built-in.

It seems the natestrauser version is basically just "fontawesome at a CDN", which Sandstorm packages should avoid: https://atmospherejs.com/natestrauser/font-awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant