Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(StateVariables): Use SharedImmutableState more consistently #4756

Closed
Tracked by #2783
LHerskind opened this issue Feb 26, 2024 · 1 comment
Closed
Tracked by #2783

refactor(StateVariables): Use SharedImmutableState more consistently #4756

LHerskind opened this issue Feb 26, 2024 · 1 comment
Assignees
@sklppy88
Labels
aztec.nr Aztec smart contract library

Comments

@LHerskind
Copy link
Contributor

LHerskind commented Feb 26, 2024 •
edited
Loading

Beware of #4735 which is to change the name of state locations (private/shared/public)

We are currently not using the SharedImmutable when we should, for example the contracts using the slow updates tree seldom store the address in SharedImmutable but instead have a public and a separate private variable for it.

Also, the macro is currently not supporting SharedImmutable of size != 1. This essentially mean that the automatic storage slot allocation will cause overlapping storage if using SharedImmutable with values with a serialized size larger than 1. See #5078 for this part.
@LHerskind LHerskind assigned LHerskind and sklppy88 and unassigned LHerskind Feb 26, 2024
@LHerskind LHerskind changed the title refactor: Use StablePublicState more consistently and fix macro refactor: Use StablePublicState more consistently Mar 8, 2024
@LHerskind LHerskind mentioned this issue Mar 8, 2024
Open
@LHerskind LHerskind changed the title refactor: Use StablePublicState more consistently refactor(AztecNr): Use StablePublicState more consistently Mar 8, 2024
@LHerskind LHerskind changed the title refactor(AztecNr): Use StablePublicState more consistently refactor(StateVariables): Use StablePublicState more consistently Mar 8, 2024
@LHerskind LHerskind changed the title refactor(StateVariables): Use StablePublicState more consistently refactor(StateVariables): Use SharedImmutableState more consistently Mar 11, 2024
@sklppy88 sklppy88 self-assigned this Mar 19, 2024
@sklppy88 sklppy88 added the aztec.nr Aztec smart contract library label Mar 21, 2024
@sklppy88
Copy link
Contributor

Closing as this seems to have already been addressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sklppy88 sklppy88

Labels
aztec.nr Aztec smart contract library
Projects
A3
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LHerskind @sklppy88