refactor: transfer and transferfrom to save constrains for simpler cases

[LHerskind]

Splits the transfer into transfer and transfer_from. transfer_from behaves as our old transfer and is expected to be useful for contracts pulling funds, while transfer is useful for pushing funds around.

The transfer only take to and amount and don't have any authwit implementation anymore. This means a reduction of a call for the case where funds are pushed.

[LHerskind]

• feat: auth registry #7035
• test: add transfer to undeployed account #7015
• refactor: transfer and transferfrom to save constrains for simpler cases #7013 👈
• refactor: note emission #7003
• refactor: split log emission to encrypt and a log, remove address input #6987
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @LHerskind and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• app_circuit_witness_generation_time_in_ms (FPC:fee_entrypoint_public): 316 (-21%)
• protocol_circuit_witness_generation_time_in_ms (private-kernel-inner): 1,148 (+19%)
• protocol_circuit_witness_generation_time_in_ms (private-kernel-tail-to-public): 8,929 (+30%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,770	1,591 (+2%)	699 (-1%)	753 (-1%)	779
proof_construction_time_sha256_30_ms	11,509 (-3%)	3,136	1,378 (-3%)	1,451	1,459 (-1%)
proof_construction_time_sha256_100_ms	44,245 (-2%)	11,871 (-3%)	5,462 (-8%)	5,441 (-6%)	5,387 (-5%)
proof_construction_time_poseidon_hash_ms	79.0 (+1%)	34.0	35.0 (+3%)	58.0 (-2%)	88.0
proof_construction_time_poseidon_hash_30_ms	1,530 (+1%)	420 (+1%)	201 (+1%)	227 (-1%)	270 (+1%)
proof_construction_time_poseidon_hash_100_ms	5,789	1,578	728 (-1%)	783 (-2%)	796 (-1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	1,412	1,412	1,412
l1_rollup_calldata_gas	9,452	9,448	9,452
l1_rollup_execution_gas	610,273	610,269	610,273
l2_block_processing_time_in_ms	748 (-1%)	1,375 (-3%)	2,677 (-1%)
l2_block_building_time_in_ms	22,760 (-1%)	45,041 (-4%)	89,473 (-1%)
l2_block_rollup_simulation_time_in_ms	22,667 (-1%)	44,752 (-4%)	89,131 (-1%)
l2_block_public_tx_process_time_in_ms	19,422 (-1%)	41,319 (-4%)	85,748 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	6,270 (-4%)	9,074 (-3%)
node_database_size_in_bytes	10,526,800	14,389,328
pxe_database_size_in_bytes	9,242	15,127

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	proving_time_in_ms	input_size_in_bytes	output_size_in_bytes	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	128 (-2%)	492 (-14%)	12,886	20,634	65,142	90,304	2,755	524,288
private-kernel-inner	383 (-1%)	⚠️ 1,148 (+19%)	49,268 (-3%)	92,854	65,142	90,304	2,755	2,097,152
private-kernel-tail	364 (-2%)	1,760 (-4%)	50,168 (-3%)	97,073	73,629	14,912	399	2,097,152
base-parity	6.37 (-2%)	1,720 (-1%)	2,741 (-2%)	128	64.0	2,208	2.00	131,072
root-parity	49.6 (-3%)	68.6 (+9%)	39,648 (-4%)	27,100	64.0	2,720	18.0	2,097,152
base-rollup	7,589 (-2%)	4,255 (-4%)	85,357 (-3%)	170,330	756	3,648	47.0	4,194,304
root-rollup	109 (-1%)	77.7 (+4%)	22,895 (-3%)	25,309	620	3,456	41.0	1,048,576
public-kernel-setup	688	2,949 (-1%)	44,656	113,321	91,286	123,296	3,786	2,097,152
public-kernel-app-logic	581 (-3%)	3,790 (-3%)	44,638 (-1%)	113,321	91,286	123,296	3,786	2,097,152
public-kernel-tail	1,152 (-3%)	30,763 (-11%)	183,570 (-1%)	412,582	10,014	14,912	399	8,388,608
private-kernel-reset-small	579 (-2%)	1,931 (-7%)	46,682 (+2%)	121,265	65,142	90,304	2,755	2,097,152
public-kernel-teardown	590	3,861 (-2%)	47,404 (+4%)	113,321	91,286	123,296	3,786	2,097,152
merge-rollup	29.3	N/A	N/A	16,542	756	N/A	N/A	N/A
private-kernel-tail-to-public	N/A	⚠️ 8,929 (+30%)	96,317 (-1%)	N/A	N/A	123,296	3,786	4,194,304
avm-circuit	N/A	N/A	3,356 (-2%)	N/A	N/A	86,117	0.00	0.00

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms	size_in_gates	num_public_inputs
ContractClassRegisterer:register	1,344	9,944	397 (-1%)	N/A	N/A	N/A	N/A
ContractInstanceDeployer:deploy	1,408	9,944	40.0 (-1%)	N/A	N/A	N/A	N/A
MultiCallEntrypoint:entrypoint	1,920	9,944	1,940 (-2%)	N/A	N/A	N/A	N/A
GasToken:deploy	1,376	9,944	929 (-1%)	N/A	N/A	N/A	N/A
SchnorrAccount:constructor	1,312	9,944	1,411 (-1%)	N/A	N/A	N/A	N/A
SchnorrAccount:entrypoint	2,304	9,944	2,767 (-2%)	16,768	53,969 (-5%)	2,097,152	457
Token:privately_mint_private_note	1,280	9,944	1,642	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_public	1,344	9,944	⚠️ 316 (-21%)	16,768	10,870 (-4%)	524,288	457
Token:transfer	1,312 (-5%)	9,944	4,803 (-3%)	16,768	51,033 (-2%)	2,097,152	457
Benchmarking:create_note	1,344	9,944	1,389 (-1%)	N/A	N/A	N/A	N/A
SchnorrAccount:spend_private_authwit	1,280	9,944	76.1	N/A	N/A	N/A	N/A
Token:unshield	1,376	9,944	3,974	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_private	1,376	9,944	4,914	N/A	N/A	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms
GasToken:_increase_public_balance	66.5 (-6%)
GasToken:set_portal	16.4 (+5%)
Token:constructor	94.6
FPC:constructor	61.2 (-3%)
GasToken:mint_public	52.6 (-1%)
Token:mint_public	524 (-3%)
Token:assert_minter_and_mint	73.1 (+28%)
SchnorrAccount:approve_public_authwit	31.8
FPC:prepare_fee	85.9 (+18%)
Token:transfer_public	41.7 (-10%)
FPC:pay_refund	66.6 (-1%)
Benchmarking:increment_balance	2,366 (-3%)
Token:_increase_public_balance	65.0 (+12%)
FPC:pay_refund_with_shielded_rebate	52.1 (-2%)

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.178 (-4%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.2 (-2%)	16.6 (-2%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.7	31.8	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.590 (-2%)	0.507 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	47.6 (-1%)	75.0 (-1%)	131 (-1%)	240 (-2%)	466 (-1%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	288	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.487 (-1%)	0.462 (-1%)	0.450	0.436 (-2%)	0.436 (-1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	58.2 (-2%)	111 (-1%)	179 (-1%)	344 (-3%)	687 (-1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	208	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.493 (-2%)	0.496 (-1%)	0.475 (-1%)	0.467 (-2%)	0.472 (-1%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	73.1 (-2%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	135	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.512 (-2%)	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	83,854	676,749

Transaction size based on fee payment method

| Metric | |
| - | |

[benesjan]

LGTM