Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container init should fail with an more explicit message if .csproj cannot be located #22

Closed
ArnaudBrousseau opened this issue Apr 6, 2018 · 1 comment

Comments

@ArnaudBrousseau
Copy link

The following message is really hard to spot unless you know where to look (in docker logs, which you have to explicitly enable) and what to look for:

echo Could not find .csproj or .dll. Using default.

I spent a fair amount of time chasing down why my app wasn't starting properly on Linux despite "successful" deployment. It turned out to be because the .csproj wasn't at the root of my git directory.

Changes proposed:

  • Make the message more explicit. Something like "Could not find your .csproj or .dll in /home/site/repository/"
  • When a .csproj isn't found, abort/fail with the more explicit version of the message. I'm not sure that it's desirable to silently fallback to /home/hostingstart/hostingstart.dll. If it's a must-have to fall back to this default dll, then fine to let this item go: displaying a more explicit message is already a win
  • Icing on the cake: display a warning if multiple .csproj/.dll are found in /home/site/repository. Something like "[WARNING] Found multiple .csproj or .dll files in /home/site/repository. Using the first one on the list (head -1)"
@patricklee2
Copy link
Contributor

we now use oryx to detection

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants