Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding editorconfig file and formatting code accordingly #134

Merged
merged 1 commit into from Jan 4, 2022
Merged

Adding editorconfig file and formatting code accordingly #134

merged 1 commit into from Jan 4, 2022

Conversation

agoncal
Copy link
Collaborator

@agoncal agoncal commented Dec 30, 2021

Purpose

Adding an .editorconfig file and formatting accordingly to the rules. EditorConfig is a nice way to have the same code formatting accross IDEs.

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[x] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Other Information

Copy link
Contributor

@mnriem mnriem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this PR contains more than just adding the .editorconfig?

Was the POMs being reformatted a result from opening it in your IDE, then please turn off automatic reformatting ;) If it is the result from applying the .editorconfig can you do it in 2 PRs?

Can you also open an issue that corresponds to the PR? This will make it easier for folks to see the changes as everything is then just tracked using issues.

Thanks!

@agoncal
Copy link
Collaborator Author

agoncal commented Jan 4, 2022

Here is the issue : #139

I've added the .editorconfig and made sure it didn't change any existing formatting rules. While scrolling around, I noticed there was some inconsistency in the formatting of the pom.xml headers (some pom.xml had the header in just one line, others split into several lines). So I manually changed the formatting

@mnriem mnriem merged commit fb98b89 into Azure-Samples:main Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants