Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the refresh parameter to the list of subscriptions #135

Merged
merged 2 commits into from Jan 5, 2022
Merged

Adding the refresh parameter to the list of subscriptions #135

merged 2 commits into from Jan 5, 2022

Conversation

agoncal
Copy link
Collaborator

@agoncal agoncal commented Dec 30, 2021

Purpose

When displaying the list of Azure subscriptions, you can get old ones that do not exist anymore, that's because the subscriptions are cached locally. Adding the refresh parameter allows the subcriptions list to be refreshed with the ones on the server.

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:

Copy link
Contributor

@mnriem mnriem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not reformat the document along with the change as it makes it hard to see what really changed.

On the note of the refresh parameter I think we should just add it to the existing command line and not add a new paragraph for it.

Note we also need a corresponding issue so folks can just keep track of what changed by looking at our issues.

@agoncal
Copy link
Collaborator Author

agoncal commented Jan 4, 2022

Here is the issue : #140

Yes, we can just leave the command with the refresh parameter.

As for the formatting, you are right. When writting in Markdown or Asciidoc I usually write one sentence per line so merging and diffs are easier (but not when you reformat everything ;o)

@agoncal agoncal merged commit 9a8e44f into Azure-Samples:main Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants