Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What about having a global SLEEP variable in the workflows ? #182

Closed
agoncal opened this issue Jan 14, 2022 · 1 comment
Closed

What about having a global SLEEP variable in the workflows ? #182

agoncal opened this issue Jan 14, 2022 · 1 comment
Labels
enhancement New feature or request stale

Comments

@agoncal
Copy link
Collaborator

agoncal commented Jan 14, 2022

This issue is for a: (mark with an x)

- [ ] bug report -> please search issues before submitting
- [x] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Mention any other details that might be useful

Some workflows fail, once in a while, in timeout. That's because, sometimes, the sleep time is not enough. For example, the following script deploys an image, waits for 3mn, and checks the app is deployed. If it's not the case, it will fail.

What about introducing a SLEEP variable that would be global for all the workflows? This way, if we see that 180s is not enough sometimes, we could easily increase it globally.

          mvn azure-webapp:deploy \
          --settings=$SETTINGS_XML \
          -DappName=$APPSERVICE_DOCKER_GLASSFISH \
          -DimageName=glassfish:latest \
          -DappServicePlan=$APPSERVICE_PLAN \
          -DresourceGroup=$RESOURCE_GROUP \
          -DserverId=$ACR_NAME
          
          
          sleep 180
          
          export RESULT=$(az webapp show --resource-group $RESOURCE_GROUP --name $APPSERVICE_DOCKER_GLASSFISH --output tsv --query state)
@agoncal agoncal added the enhancement New feature or request label Jan 14, 2022
@mnriem
Copy link
Contributor

mnriem commented Jul 4, 2022

This issue is stale because it has been open 170 days with no activity. Remove stale label or comment or this will be closed in 10 days

@mnriem mnriem added the stale label Jul 4, 2022
@mnriem mnriem closed this as completed Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

2 participants