Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Synapse Terraform Recipe #27

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Adding Synapse Terraform Recipe #27

wants to merge 5 commits into from

Conversation

promisinganuj
Copy link
Contributor

@promisinganuj promisinganuj commented Feb 1, 2023 •
edited

Purpose

Closes: #26

  • Adding terraform version of Azure Synapse recipe.

Does this introduce a breaking change?

[x] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@promisinganuj promisinganuj temporarily deployed to virtual-network-integration-recipes February 1, 2023 02:58 — with GitHub Actions Inactive
@promisinganuj promisinganuj temporarily deployed to virtual-network-integration-recipes February 1, 2023 02:58 — with GitHub Actions Inactive
@promisinganuj promisinganuj temporarily deployed to virtual-network-integration-recipes February 1, 2023 02:58 — with GitHub Actions Inactive
@promisinganuj promisinganuj temporarily deployed to virtual-network-integration-recipes February 1, 2023 02:58 — with GitHub Actions Inactive
@promisinganuj promisinganuj temporarily deployed to virtual-network-integration-recipes February 1, 2023 02:58 — with GitHub Actions Inactive
@promisinganuj promisinganuj temporarily deployed to virtual-network-integration-recipes February 1, 2023 02:58 — with GitHub Actions Inactive
@promisinganuj promisinganuj temporarily deployed to virtual-network-integration-recipes February 1, 2023 02:58 — with GitHub Actions Inactive
@promisinganuj promisinganuj temporarily deployed to virtual-network-integration-recipes February 1, 2023 02:58 — with GitHub Actions Inactive
@promisinganuj promisinganuj temporarily deployed to virtual-network-integration-recipes February 1, 2023 02:58 — with GitHub Actions Inactive
@promisinganuj promisinganuj temporarily deployed to virtual-network-integration-recipes February 1, 2023 02:58 — with GitHub Actions Inactive
@promisinganuj promisinganuj self-assigned this Feb 1, 2023
@promisinganuj promisinganuj added the enhancement New feature or request label Feb 1, 2023
@promisinganuj
Copy link
Contributor Author

@jchomarat , this is the draft PR which you can refer to. If it's easy, we can still keep the individual modules within the recipe folder and migrate it all together to use common modules in a separate project.

@promisinganuj promisinganuj temporarily deployed to virtual-network-integration-recipes March 15, 2023 03:09 — with GitHub Actions Inactive
@promisinganuj promisinganuj temporarily deployed to virtual-network-integration-recipes March 15, 2023 03:09 — with GitHub Actions Inactive
@promisinganuj promisinganuj temporarily deployed to virtual-network-integration-recipes March 15, 2023 03:09 — with GitHub Actions Inactive
@promisinganuj promisinganuj temporarily deployed to virtual-network-integration-recipes March 15, 2023 03:09 — with GitHub Actions Inactive
@promisinganuj promisinganuj temporarily deployed to virtual-network-integration-recipes March 15, 2023 03:09 — with GitHub Actions Inactive
@promisinganuj promisinganuj temporarily deployed to virtual-network-integration-recipes March 15, 2023 03:09 — with GitHub Actions Inactive
@promisinganuj promisinganuj temporarily deployed to virtual-network-integration-recipes March 15, 2023 05:33 — with GitHub Actions Inactive
@promisinganuj promisinganuj temporarily deployed to virtual-network-integration-recipes March 15, 2023 05:33 — with GitHub Actions Inactive
@promisinganuj promisinganuj temporarily deployed to virtual-network-integration-recipes March 15, 2023 05:33 — with GitHub Actions Inactive
@promisinganuj promisinganuj temporarily deployed to virtual-network-integration-recipes March 15, 2023 05:33 — with GitHub Actions Inactive
@promisinganuj promisinganuj temporarily deployed to virtual-network-integration-recipes March 15, 2023 05:33 — with GitHub Actions Inactive
@promisinganuj promisinganuj temporarily deployed to virtual-network-integration-recipes March 15, 2023 05:33 — with GitHub Actions Inactive
@promisinganuj promisinganuj temporarily deployed to virtual-network-integration-recipes March 15, 2023 06:06 — with GitHub Actions Inactive
@promisinganuj promisinganuj temporarily deployed to virtual-network-integration-recipes March 15, 2023 06:06 — with GitHub Actions Inactive
@promisinganuj promisinganuj temporarily deployed to virtual-network-integration-recipes March 15, 2023 06:06 — with GitHub Actions Inactive
@promisinganuj promisinganuj temporarily deployed to virtual-network-integration-recipes March 15, 2023 06:06 — with GitHub Actions Inactive
@promisinganuj promisinganuj temporarily deployed to virtual-network-integration-recipes March 15, 2023 06:06 — with GitHub Actions Inactive
@promisinganuj promisinganuj temporarily deployed to virtual-network-integration-recipes March 15, 2023 06:06 — with GitHub Actions Inactive
@promisinganuj promisinganuj temporarily deployed to virtual-network-integration-recipes March 15, 2023 06:08 — with GitHub Actions Inactive
@promisinganuj promisinganuj temporarily deployed to virtual-network-integration-recipes March 15, 2023 06:08 — with GitHub Actions Inactive
@promisinganuj promisinganuj temporarily deployed to virtual-network-integration-recipes March 15, 2023 06:08 — with GitHub Actions Inactive
@promisinganuj promisinganuj temporarily deployed to virtual-network-integration-recipes March 15, 2023 06:08 — with GitHub Actions Inactive
@promisinganuj promisinganuj deployed to virtual-network-integration-recipes March 15, 2023 06:08 — with GitHub Actions Active
@promisinganuj promisinganuj temporarily deployed to virtual-network-integration-recipes March 15, 2023 06:08 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devlace devlace Awaiting requested review from devlace

@mcollier mcollier Awaiting requested review from mcollier

At least 1 approving review is required to merge this pull request.

Assignees

@promisinganuj promisinganuj

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add terraform version for Synapse recipe
1 participant
@promisinganuj