Fix Atlassian Confluence API parameter #4539

nevermoe · 2022-03-30T12:56:25Z

Required items, please complete

Change(s):

Fix Atlassian Confluence API parameter

Reason for Change(s):

The audit API of confluence takes startDate and endData as a parameter. These two paramters should be in utc timestampe format but the current implementation passed a datetime string. And thus the function app is not retrieving any log from the API. See: https://developer.atlassian.com/cloud/confluence/rest/api-group-audit/#api-wiki-rest-api-audit-get

Version Updated:

N/A

Testing Completed:

Only tested in my personal environment

Checked that the validations are passing and have addressed any issues that are present:

N/A

ghost · 2022-03-30T12:56:38Z

All CLA requirements met.

v-marimanda · 2022-03-31T11:14:07Z

@nevermoe Please update the changes in zip file. thanks!!!

nevermoe · 2022-04-01T03:58:28Z

@vmanojreddy Hi, I just updated the init.py and host.json in the zip file. I don't know if I should update the .python_packages directory in the zip file so I just leave it unchanged.
Thanks!

v-marimanda · 2022-04-01T11:23:03Z

Tested the data connector by deploying the function app. we see error for function. Please check and update. Thanks.

nevermoe · 2022-04-01T12:11:56Z

@vmanojreddy Hi, sorry I didn't test that case. I think I fixed this bug. Would you please test deploy again? Thanks!

v-marimanda · 2022-04-04T07:35:49Z

@nevermoe Tested the data connector by deploying the function app. Still we are getting error for function. Please check and update. Thanks!!!

nevermoe · 2022-04-04T07:44:23Z

@vmanojreddy
Hi, thank you for testing. I checked the zip file and the init.py is successfully updated. However, from the error message, it indicates that it's using an old version of init.py. Is the init.py cached somewhere else?

nevermoe · 2022-04-07T06:42:36Z

@vmanojreddy Hi, Any updates here?

v-marimanda · 2022-04-07T10:30:45Z

@nevermoe Tested the data connector by deploying the function app. Still we are getting error in function. Please check and update. Thanks!!!

nevermoe · 2022-04-07T10:48:48Z

@vmanojreddy Hi, The error code is 404 which indicates there is something wrong with the confluence URL. Are you sure the tested confluence domain is correct? Because I made no change in this function, it's probably some configuration problem. If you can provide more information of the http request/response log, it would be more easy for me to locate the problem.

nevermoe · 2022-04-11T14:34:09Z

@vmanojreddy Hi, do we have any progress here?

v-marimanda · 2022-04-12T07:39:41Z

Hi @nevermoe sorry for late, I deployed the function app again with proper Confluence URL. Still we are getting error in function. Please check and update. Thanks!!!

nevermoe · 2022-04-12T10:04:53Z

@vmanojreddy Hi, the time format written to the funcstatemarkerfile in storage account is in old format. I am doubting that some old version of function apps is running and writing strings to this file. Would you please have a check that all the function apps and the storage accounts deployed previously are deleted and deploy this new version again?

nevermoe · 2022-04-18T07:47:41Z

@vmanojreddy Hi, how's everything going

v-marimanda · 2022-04-20T09:18:45Z

Hi @nevermoe I am working and trying to deploy i am facing issues. I will check and update you. thanks!!!

nevermoe · 2022-04-20T10:21:02Z

@vmanojreddy Thank you very much for your help! Looking forward to hearing good news!

nevermoe · 2022-05-10T02:50:37Z

@vmanojreddy Hi, just to check, how's everything going?

v-mchatla · 2022-09-08T08:30:54Z

Hi @nevermoe
I have tried deleting and redeploying the function app, storage account and dependent resources. As you have applied condition on the past_time in the file init.py line:38, that issue was fixed. But we are still getting other errors, please add not null or empty check on the result variable on line 84 and also it would be great if you can add more custom exceptions wherever you feel like breaking, so that it will be easier to identify the issue.

v-spadarthi · 2022-09-12T08:18:29Z

Hi @nevermoe
Could you please resolve the above comments and conflicts as well. Thanks!!

v-mchatla · 2022-09-16T05:37:52Z

Hi @nevermoe
Do we have any update on the changes requested. Please let us know if you need any clarification
Thanks

v-mchatla · 2022-09-20T05:37:05Z

Hi @nevermoe
Could you please resolve the comments, so that we can verify and merge your changes.
Thanks

v-mchatla · 2022-09-22T15:07:29Z

Hi @nevermoe
Sorry for multiple follow ups, can you please resolve the comments.
Thanks

nevermoe · 2022-09-22T15:54:20Z

@v-mchatla @v-spadarthi Hi, thank GOD you guys finally come back to review this issue. You got a 404 error so it's likely you entered a wrong confluence url when using the ARM. E.g. for site like https://xxxxxxxxx.atlassian.net/, you should only enter the xxxxxxxxx part in ConfluenceHomeSiteName.

v-mchatla · 2022-09-27T13:56:18Z

@v-mchatla @v-spadarthi Hi, thank GOD you guys finally come back to review this issue. You got a 404 error so it's likely you entered a wrong confluence url when using the ARM. E.g. for site like https://xxxxxxxxx.atlassian.net/, you should only enter the xxxxxxxxx part in ConfluenceHomeSiteName.

Hi @nevermoe,
We don't have any test data for this to test. Can you please provide some test data if you have, otherwise I will check with team on how to proceed in this case and update you.
Thanks.

nevermoe · 2022-09-28T05:44:52Z

@v-mchatla I don't have any test data. The test should be run with a JIRA service and I think you have tested the JIRA connection successfully before according to this thread.

v-mchatla · 2022-09-30T05:22:23Z

Hi @nevermoe
Please resolve the conflicts. I will try to test once again and let you know the result.
Thanks

nevermoe · 2022-09-30T12:18:48Z

@v-mchatla Hi, I think the conflicts are resolved.

v-mchatla · 2022-10-04T19:12:03Z

Hi @nevermoe
Thanks for resolving the conflicts. I will check with my team on how to proceed in this case as we don't have test data to do thorough testing and will update you soon.
Thanks

v-mchatla · 2022-10-07T05:08:43Z

Hi @nevermoe
We are still working on it, will update you soon.
Thanks

v-spadarthi · 2022-10-11T06:06:18Z

@v-mchatla : Please have a look and update

v-mchatla · 2022-10-14T06:01:47Z

Hi @nevermoe
Sorry for the delay. I will be working on it today and provide you the update.
Thanks

v-mchatla · 2022-10-17T07:14:33Z

Hi @nevermoe,
I tried retesting the function app by redeploying but still getting the same error. I don't have test Confluence URL. If this function app is working fine in your environment, then we are good. Please confirm on the same so that we can proceed further.

Thanks

nevermoe · 2022-10-17T11:08:35Z

@v-mchatla Hi, the errors shows HOMESITENAME.atlassian.net.atlassian.net is NOT a valid URL and apparently you didn't input a valid HOMESITENAME. I think in some previous comments some guy in your team managed to test it with your own Confluence URL. Anyway, these codes run good in my environment but if you can't test it, I can't help with that.

v-mchatla · 2022-10-19T06:09:27Z

Hi @nevermoe,
Thanks for the confirmation. I will just validate all the files and approve this PR in sometime.
Thanks

v-mchatla · 2022-10-19T12:47:43Z

Hi @nevermoe,
I could see 2 host.json files. Do we need both or just keep which one is required?
Thanks

nevermoe · 2022-10-21T01:14:59Z

@v-mchatla Hi, I removed the unnecessary host.json.

v-mchatla · 2022-10-21T05:42:32Z

Hi @nevermoe,
Thanks for the quick response. Checks are running at my end. Once all the checks are passed, I will approve and merge the PR

v-mchatla

Approving the PR

nevermoe added 4 commits March 30, 2022 15:01

update

8157b33

update timestampe

2433858

remove vscode file

15db41c

remove vscode file

5f1ac63

nevermoe requested review from NoamLandress, shschwar, ashishsyal and preetikr as code owners March 30, 2022 12:56

v-spadarthi added the Connector Connector specialty review needed label Mar 30, 2022

v-spadarthi assigned v-marimanda Mar 30, 2022

update zip file

a548c8b

nevermoe requested a review from haim-na as a code owner April 1, 2022 03:31

fix initial time is None bug

0bc035b

change link to mine

e4916e6

add error msg

3afaa19

remove local.settings.json

d7e8cbb

v-mchatla assigned v-mchatla and unassigned v-marimanda Sep 30, 2022

resolve conflict

303122c

nevermoe requested a review from a team as a code owner September 30, 2022 12:17

remove unintended host.json

a33da8c

v-mchatla approved these changes Oct 25, 2022

View reviewed changes

v-mchatla merged commit 1f92576 into Azure:master Oct 25, 2022

Fix Atlassian Confluence API parameter #4539

Fix Atlassian Confluence API parameter #4539

Conversation

nevermoe commented Mar 30, 2022

ghost commented Mar 30, 2022 • edited by ghost

v-marimanda commented Mar 31, 2022

nevermoe commented Apr 1, 2022

v-marimanda commented Apr 1, 2022

nevermoe commented Apr 1, 2022

v-marimanda commented Apr 4, 2022

nevermoe commented Apr 4, 2022 • edited

nevermoe commented Apr 7, 2022

v-marimanda commented Apr 7, 2022

nevermoe commented Apr 7, 2022

nevermoe commented Apr 11, 2022

v-marimanda commented Apr 12, 2022

nevermoe commented Apr 12, 2022

nevermoe commented Apr 18, 2022

v-marimanda commented Apr 20, 2022

nevermoe commented Apr 20, 2022

nevermoe commented May 10, 2022

v-mchatla commented Sep 8, 2022

v-spadarthi commented Sep 12, 2022

v-mchatla commented Sep 16, 2022

v-mchatla commented Sep 20, 2022

v-mchatla commented Sep 22, 2022

nevermoe commented Sep 22, 2022

v-mchatla commented Sep 27, 2022

nevermoe commented Sep 28, 2022

v-mchatla commented Sep 30, 2022

nevermoe commented Sep 30, 2022

v-mchatla commented Oct 4, 2022

v-mchatla commented Oct 7, 2022

v-spadarthi commented Oct 11, 2022

v-mchatla commented Oct 14, 2022

v-mchatla commented Oct 17, 2022

nevermoe commented Oct 17, 2022

v-mchatla commented Oct 19, 2022

v-mchatla commented Oct 19, 2022

nevermoe commented Oct 21, 2022

v-mchatla commented Oct 21, 2022

v-mchatla left a comment

Choose a reason for hiding this comment

ghost commented Mar 30, 2022 •

edited by ghost

nevermoe commented Apr 4, 2022 •

edited