Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Playbooks/Enrich-MalwareBazaar #7060

Merged
merged 5 commits into from Feb 3, 2023

Conversation

juju4
Copy link
Contributor

@juju4 juju4 commented Jan 8, 2023

Change(s):

Reason for Change(s):

  • Data Enrichment

Version Updated:

  • N/A

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • Yes

@juju4 juju4 requested review from a team as code owners January 8, 2023 16:57
@v-atulyadav v-atulyadav added the Playbook Playbook specialty review needed label Jan 9, 2023
@v-atulyadav
Copy link
Contributor

Hi @rahul0216, can you please review this and provide your feedback accordingly. Thanks.

@v-atulyadav
Copy link
Contributor

Hi @rahul0216, can you please provide your feedback accordingly. Thanks

@manishkumar1991
Copy link
Contributor

@juju4 ,
for creating the playbooks arm template
kindly use the playbook arm template generator tool for creating the playbook template and then fill out all the necessary meta data ,

Kindly check below link for arm template generator
https://github.com/Azure/Azure-Sentinel/tree/master/Tools/Playbook-ARM-Template-Generator

And then kindly fill up the meta data details as well
kindly check below link for reference on metadata details
https://github.com/Azure/Azure-Sentinel/tree/master/Solutions/ThreatXCloud/Playbooks/ThreatXPlaybooks/ThreatX-BlockIP-URL

@juju4
Copy link
Contributor Author

juju4 commented Jan 14, 2023

Metadata added.

As said in other PR, Thanks for the Playbook-ARM-Template-Generator reference. I will use it next time.

@v-atulyadav
Copy link
Contributor

Hi @juju4, please respond on @manishkumar1991 comments. Thanks.

@v-atulyadav
Copy link
Contributor

Hi @manishkumar1991, @juju4 has responded to your comments, please check and respond accordingly. Thanks

@manishkumar1991
Copy link
Contributor

Hi @manishkumar1991, @juju4 has responded to your comments, please check and respond accordingly. Thanks

I will check and respond.

Copy link
Contributor

@manishkumar1991 manishkumar1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@v-dvedak v-dvedak merged commit 70e5d66 into Azure:master Feb 3, 2023
@juju4
Copy link
Contributor Author

juju4 commented Feb 4, 2023

Thanks!

@juju4 juju4 deleted the devel-malwarebazaar branch February 4, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Playbook Playbook specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants