Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] SDK crash if user input an invalid teams meeting link on beta 9.0 #198

Closed
AmyL219 opened this issue Feb 22, 2021 · 4 comments
Closed

[iOS] SDK crash if user input an invalid teams meeting link on beta 9.0 #198

AmyL219 opened this issue Feb 22, 2021 · 4 comments
Assignees
@raosanat
Labels
ADO Linked This issue has an ADO Item on our ADO. Bug Something isn't working Calling Issue involves Calling functionality. iOS Issues involving the iOS SDK Needs: attention 👋 Teams interop

Comments

@AmyL219
Copy link
Member

AmyL219 commented Feb 22, 2021 •
edited
Loading

Describe the bug
When the TeamsMeetingLinkLocator is initialized by an invalid meeting link, the SDK would crash with an ACSException
Screen Shot 2021-02-22 at 11 29 47 AM

To Reproduce
Steps to reproduce the behavior:

  1. create TeamsMeetingLinkLocator with an invalid meeting link
    let teamsMeetingLinkLocator = TeamsMeetingLinkLocator(meetingLink: "https://teams.microsoft.com/l/meetup-join/19%3")
  2. let CallAgent join with the link locator
    CallAgent.join(with:teamsMeetingLinkLocator)
  3. App would crash on running time

Expected behavior
App shouldn't crash

Smartphone (please complete the following information):

  • Device: iphone 11
  • OS: iOS 14.4
  • Version beta 8.0 & 9.0

Logs
xcappdata22.xcappdata.zip
@AmyL219 AmyL219 added the Bug Something isn't working label Feb 22, 2021
@ghost ghost added the Needs: triage 🔍 label Feb 22, 2021
@akania akania added Calling Issue involves Calling functionality. iOS Issues involving the iOS SDK Needs: attention 👋 Teams interop and removed Needs: triage 🔍 labels Feb 22, 2021
@AmyL219 AmyL219 changed the title [iOS] SDK crash if user input an invalid teams meeting link on beta 8.0 [iOS] SDK crash if user input an invalid teams meeting link on beta 9.0 Mar 17, 2021
@AmyL219
Copy link
Member Author

AmyL219 commented Mar 17, 2021

ADO ticket

@raosanat
Copy link
Member

Fixed in beta.12 release.

@raosanat
Copy link
Member

Still reproducible, figured out the issue will fix in next release.

@raosanat raosanat reopened this Apr 29, 2021
@RinaRish RinaRish added the ADO Linked This issue has an ADO Item on our ADO. label Jun 4, 2021
@raosanat
Copy link
Member

Fixed in the latest release v2.1.0-beta.1.
Please re-open the bug if still reproducible, thanks.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@raosanat raosanat

Labels
ADO Linked This issue has an ADO Item on our ADO. Bug Something isn't working Calling Issue involves Calling functionality. iOS Issues involving the iOS SDK Needs: attention 👋 Teams interop
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@akania @RinaRish @raosanat @AmyL219