Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onRemoteParticipantsUpdated update the participant state to .idle when the participant is inLobby #221

Closed
AmyL219 opened this issue Mar 9, 2021 · 5 comments
Assignees
Labels
Bug Something isn't working iOS Issues involving the iOS SDK Known Issue Issue has been created by ACS Team for external Visibility Teams interop

Comments

@AmyL219
Copy link
Member

AmyL219 commented Mar 9, 2021

Describe the bug
The remote participant state is not correct when the participant is waiting permission in Teams room. The state of the participant is .idle rather than .inLobby.
Not sure if it's expected or a bug. Please let me know.

Do you have any documentation about when the value of ACSParticipantState/ACSCallState would change?
The document can help us in determining how to handle each state change. I only can find the [description] of each state. (https://docs.microsoft.com/en-us/objectivec/communication-services/calling/acsparticipantstate) .

To Reproduce
Steps to reproduce the behavior:

  1. Use Calling SDK to join a Teams meeting and get the permission
  2. Use web browser to join the Teams meeting as a guest user, don't give him permission of join
  3. onRemoteParticipantsUpdated get fired, and the new guest user added, but the state of the participant is .idle rather than .inLobby

Expected behavior
The state of the participant who is waiting in Lobby for permission should be .inLobby rather than idle

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • Version: beta 8.0
@AmyL219 AmyL219 added the Bug Something isn't working label Mar 9, 2021
@ghost ghost added the Needs: triage 🔍 label Mar 9, 2021
@ashishvirani7 ashishvirani7 added iOS Issues involving the iOS SDK Teams interop labels Mar 10, 2021
@ashishvirani7 ashishvirani7 self-assigned this Mar 10, 2021
@AmyL219
Copy link
Member Author

AmyL219 commented Mar 12, 2021

ADO ticket

@ProbablePrime ProbablePrime added Known Issue Issue has been created by ACS Team for external Visibility and removed Needs: triage 🔍 labels Mar 16, 2021
@ProbablePrime ProbablePrime changed the title [iOS][Teams Interops] onRemoteParticipantsUpdated update the participant state to .idle when the participant is inLobby onRemoteParticipantsUpdated update the participant state to .idle when the participant is inLobby Mar 16, 2021
@akania
Copy link
Member

akania commented Mar 18, 2021

@AmyL219 can you please provide more details

  1. is there a Teams user who admits user who joins with " Calling SDK"
  2. " Calling SDK" - that's iOS ?
  3. "onRemoteParticipantsUpdated get fired,..." - that's observed on "Calling SKD " side ?

@AmyL219
Copy link
Member Author

AmyL219 commented Mar 22, 2021

@akania

  1. The scenario is when the app user (named A) is connected to an ongoing Teams meeting, there is another app/web guest user (named B) want to join the meeting and waiting in lobby. When app user A gets a addOnRemoteParticipantsUpdated, and accesses to userB.getState(), it returns idle rather than inLobby. When someone admits userB to the meeting, the userB.getState() would become connected which is sensible.
    I doubt if it's sensible when a user is waiting in lobby, other participants read the user's state as IDLE?
    Screen Shot 2021-03-22 at 1 55 12 PM
    Screen Shot 2021-03-22 at 1 46 27 PM

@AmyL219
Copy link
Member Author

AmyL219 commented Mar 22, 2021

  1. I just test Android. So this issue exists both on iOS and Android
  2. Yes, on the delegate for iOS and listener on Android

@ashishvirani7
Copy link
Contributor

@AmyL219 Thanks for reporting! This is fixed for both Android/iOS and it will be available in next release!

@ghost ghost locked as resolved and limited conversation to collaborators May 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working iOS Issues involving the iOS SDK Known Issue Issue has been created by ACS Team for external Visibility Teams interop
Projects
None yet
Development

No branches or pull requests

5 participants