Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turning the local video off/on quickly shows a blank local video #225

Closed
iaulakh opened this issue Mar 11, 2021 · 6 comments
Closed

Turning the local video off/on quickly shows a blank local video #225

iaulakh opened this issue Mar 11, 2021 · 6 comments
Assignees
@sankum-msft
Labels
ADO Linked This issue has an ADO Item on our ADO. Android Issues involving the Android SDK Bug Something isn't working Calling Issue involves Calling functionality. Known Issue Issue has been created by ACS Team for external Visibility

Comments

@iaulakh
Copy link
Member

iaulakh commented Mar 11, 2021 •
edited by ProbablePrime
Loading

Describe the bug
As Renderer is created from LocalVideoStream and we can not bind LocalVideoStream to two renderer. Once we dispose Render, the LocalVideoStream can not be bind to other Render immediately. The new Render does not show LocalVideoStream. However, if after Render dispose We wait for a second and create new Render then it shows video. [azure-communication-calling:1.0.0-beta.8]

To Reproduce
Steps to reproduce the behavior:

  1. turn on camera
  2. toggle camera button (turn off, then turn on)
  3. video is not displayed

Expected behavior
On quick camera button toggle the video feed should be displayed.

Additional context
As per communication with SDK team "There is a bug in that path where dispose returns before the full cleanup."

  • [azure-communication-calling:1.0.0-beta.8]

[https://skype.visualstudio.com/SPOOL/_workitems/edit/2399773](Azure Bug)
@iaulakh iaulakh added the Bug Something isn't working label Mar 11, 2021
@ghost ghost added the Needs: triage 🔍 label Mar 11, 2021
@ProbablePrime ProbablePrime added Calling Issue involves Calling functionality. Needs: attention 👋 and removed Needs: triage 🔍 labels Mar 11, 2021
@ProbablePrime ProbablePrime added ADO Linked This issue has an ADO Item on our ADO. Known Issue Issue has been created by ACS Team for external Visibility and removed Needs: attention 👋 labels Mar 16, 2021
@ProbablePrime ProbablePrime changed the title [Android][azure-communication-calling:1.0.0-beta.8]Turning the local video off/on quickly shows a blank local video Turning the local video off/on quickly shows a blank local video Mar 16, 2021
@raosanat
Copy link
Member

This is resolved in the latest build. Please verify and re-open again if you still see issues. Thanks.

@raosanat
Copy link
Member

Closed by mistake, assuming it was iOS.

@raosanat raosanat reopened this Apr 28, 2021
@kagbakpem
Copy link
Contributor

@iaulakh, can you please test this on the latest SDK version (1.0.0) freshly released yesterday? ty

@kagbakpem kagbakpem added the Android Issues involving the Android SDK label Apr 28, 2021
@iaulakh
Copy link
Member Author

iaulakh commented May 3, 2021

@iaulakh, can you please test this on the latest SDK version (1.0.0) freshly released yesterday? ty

Thanks @kagbakpem. I will test this week and will leave comments once done.

@iaulakh
Copy link
Member Author

iaulakh commented May 16, 2021

works fine. Thanks @kagbakpem

@kagbakpem
Copy link
Contributor

Great, thx for the update, @iaulakh.

@ghost ghost locked as resolved and limited conversation to collaborators Jun 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sankum-msft sankum-msft

Labels
ADO Linked This issue has an ADO Item on our ADO. Android Issues involving the Android SDK Bug Something isn't working Calling Issue involves Calling functionality. Known Issue Issue has been created by ACS Team for external Visibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ProbablePrime @kagbakpem @sankum-msft @raosanat @iaulakh