Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speaking Change Listeners were triggered unexpectedly #234

Closed
lpx1989 opened this issue Mar 14, 2021 · 2 comments
Closed

Speaking Change Listeners were triggered unexpectedly #234

lpx1989 opened this issue Mar 14, 2021 · 2 comments
Assignees
Labels
ADO Linked This issue has an ADO Item on our ADO. Android Issues involving the Android SDK Bug Something isn't working Calling Issue involves Calling functionality. Known Issue Issue has been created by ACS Team for external Visibility

Comments

@lpx1989
Copy link

lpx1989 commented Mar 14, 2021

Describe the bug
The speaking change event was triggered not properly. When turning on mic for one of remote participants from web clients, the speaking change event was triggered for multiple remote participants which messed up the participants' view update on Android device screen.

To Reproduce
Steps to reproduce the behavior:

When testing for the Android Calling Sample regarding of the participants view update when off-screen participant's speaking change listener was triggered. I have 4 remote participants joined from web client and one local participant. At the beginning, user 01 02 03 and local user showed up on the screen while user 04 was off screen.
Then I started my testing steps:
turn on mic for user 04, the expected result : 04 01 02 & local user on screen, 03 was off screen.
turn on mic for user 03, ............................result: 03 04 01 & local user on screen, 02 was off screen.
........................................ 02, ............................result: 02 03 04 & local user on screen, 01 was off screen.
continue this process......

Expected behavior
When speaking event is triggering for a certain remote participant, it should not trigger events for others' whose mic is off.

Smartphone (please complete the following information):

  • Device: Pixel 4a
  • OS: Android 11
  • Version This problem was noticed in beta6 & 7 calling sdk for android and continue show up in beta8 (but for beta8 it only happens for the first time triggering in the call)

Additional context
The link to the ADO ticket https://skype.visualstudio.com/SPOOL/_workitems/edit/2361930

@lpx1989 lpx1989 added the Bug Something isn't working label Mar 14, 2021
@ghost ghost added the Needs: triage 🔍 label Mar 14, 2021
@ProbablePrime ProbablePrime added ADO Linked This issue has an ADO Item on our ADO. Android Issues involving the Android SDK Calling Issue involves Calling functionality. Known Issue Issue has been created by ACS Team for external Visibility and removed Needs: triage 🔍 labels Mar 16, 2021
@raosanat
Copy link
Member

@kagbakpem this is now resolved right ?

@kagbakpem
Copy link
Contributor

Yes, this is now resolved. Please make sure to also check the isSpeaking property on the RemoteParticipant to render the speaking status. ty

@ghost ghost locked as resolved and limited conversation to collaborators May 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ADO Linked This issue has an ADO Item on our ADO. Android Issues involving the Android SDK Bug Something isn't working Calling Issue involves Calling functionality. Known Issue Issue has been created by ACS Team for external Visibility
Projects
None yet
Development

No branches or pull requests

4 participants