Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new test plans for VNET to VNET testing #297

Merged
merged 12 commits into from Jan 19, 2023

Conversation

murthyvijay
Copy link
Contributor

@murthyvijay murthyvijay commented Dec 8, 2022

  • SONiC test plan template is placed here and can be used as a reference for future test plans
  • All future DASH test plans may follow the same template; ensures uniformity
  • Included images to denote testbed topology and ixia-c based test setup deployment
  • Basic feature functionality of Virtual Networks (VNET) is tested while traffic generator emulate various traffic patterns
  • Covers test cases written for:
    • Traffic originating in one VNET and terminating on another VNET and observing functionality of the DUT
    • Communication across two virtual machines in different VNETs
    • Virtual Machines with IPv4/IPv6 addressing
    • ACL features like allow and deny

@murthyvijay
Copy link
Contributor Author

murthyvijay commented Dec 8, 2022

@microsoft-github-policy-service agree company="Keysight"

Copy link
Collaborator

@chrispsommers chrispsommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor clarifications requested, thanks.

The recommendation was to de-duplicate the SONiC test plan template and referenced it to its original placeholder
Removing the test plan template as the link to it is provided in the README file
Removed the diagram and referenced to the original VNET service document under DASH documentation
Since the original document is reference, no need for the VM to VM communication svg file here
@murthyvijay murthyvijay requested review from chrispsommers and lguohan and removed request for chrispsommers and lguohan December 21, 2022 06:14
rectified the incorrect VNET service link to reflect the correct one
Rectified some typos in the document
Copy link
Collaborator

@chrispsommers chrispsommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reuse existing diagram unless there is an issue.

@KrisNey-MSFT
Copy link
Collaborator

KrisNey-MSFT commented Jan 12, 2023

@xumia can you help us with the new Easy CLA check that was added (and PRs now not passing) please?

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 17, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@KrisNey-MSFT KrisNey-MSFT merged commit 9d9c229 into sonic-net:main Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants