Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vscode): Update calls to check for dotnet installation #4621

Merged
merged 4 commits into from
Apr 16, 2024

Conversation

ccastrotrejo
Copy link
Contributor

This pull request primarily focuses on refactoring the way the .NET Core SDK validation is performed in the vs-code-designer application. The validateDotNetIsInstalled function has been moved to a different location and its usage has been updated in several files. The function's signature has also been modified to remove the message parameter.

  • The message parameter was removed from the validateDotNetIsInstalled function. Instead, the message is now defined directly within the function.

  • Imported the validateDotNetIsInstalled function from a new location.

  • Removed the import of validateDotnetInstalled and imported the validateDotNetIsInstalled function from a new location.

  • Updated the call to validateDotNetIsInstalled in the createStep method to match the new function signature.

  • Updated the call to validateDotNetIsInstalled in the switchToDotnetProject function to match the new function signature.

  • Removed the call to validateDotnetInstalled in the getLatestTemplates method.

@ccastrotrejo ccastrotrejo merged commit 97706a6 into main Apr 16, 2024
10 checks passed
@ccastrotrejo ccastrotrejo deleted the ccastrotrejo/fixCheckDotnet branch April 16, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants