fix(Designer): Updated HTML Editor to support newline characters (for dynamic content) #4635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-B-Wu
approved these changes
Apr 18, 2024
Eric-B-Wu
added a commit
that referenced
this pull request
May 8, 2024
…or monitoring view (#4775) * add UTC to monitoring times * moved changes * update * update specs * fix * Update snapshots * see if this works * remove unnecssary code * Revert "fix(Designer): Updated HTML Editor to support newline characters (for dynamic content) (#4635)" This reverts commit f4e1f8b. * testing if this fixes * more attempts * more attempts * adding unit tests * readding file and praying it works * please give me some coverage! --------- Co-authored-by: Travis Harris <travisharris@microsoft.com> Co-authored-by: Travis Harris <hartra344@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug with the HTML Editor where the HTML Editor cannot support newline characters.
When a user adds dynamic content to any action with an HTML Editor and adds a newline character (for example, by pressing the 'enter' key) and then closes the action, reopening the action will cause the dynamic content to disappear. The dynamic content should stay in the action's HTML Editor, but it does not stay because the HTML Editor does not support newline characters.
Bug 26654763: Expression gets lost when newline is used
My change enables the HTML Editor to support newline characters. With my change, a user can add newline characters to the HTML Editor for dynamic content and the newline character (and dynamic content) will be preserved. It will not spontaneously disappear (as seen in the bug linked above). This improves the user experience for LA Designer users because it ensures the HTML Editor can support newline characters.
This PR does not break any existing functionality. Rather, it only adds to the functionality of the HTML Editor by supporting newline characters.
Added a newline character after the 'a' in email:
Upon reopening the HTML-to-Text action, the dynamic content with newline character remains. Previously, HTML-to-Text field would appear blank (incorrectly):