Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(desinger): Move non-outputschema dynamic data outside fetch #4656

Merged
merged 1 commit into from Apr 19, 2024

Conversation

Eric-B-Wu
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Fixes Designer saving default values for Initiate Variables as strings #4648

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Please Include Screenshots or Videos of the intended change:

@Eric-B-Wu Eric-B-Wu merged commit 3afadda into main Apr 19, 2024
10 checks passed
@Eric-B-Wu Eric-B-Wu deleted the eric/updateDynamicData branch April 19, 2024 15:44
shuktika12163 pushed a commit to shuktika12163/LogicAppsUX that referenced this pull request May 7, 2024
Eric-B-Wu added a commit that referenced this pull request May 8, 2024
* fix(desinger): Move non-outputschema dynamic data outside fetch (#4656)

move logic outside fetch

* fix(Designer): Remove react query for dynamic data (#4693)

* fix(designer): fix issue where scope nodes didn't get focused when they were jumped to

* small pr

* upload

* update

---------

Co-authored-by: Travis Harris <travisharris@microsoft.com>

* fix(designer): Fixing clearing of dynamic inputs of parameter value changes (#4702)

Co-authored-by: Priti Sambandam <psamband@microsoft.com>

* fix(designer): Adding dispatch call in clear dynamic inputs (#4712)

* fix(designer): Fixing clearing of dynamic inputs of parameter value changes

* fix(designer): Adding dispatch call in store update to clear dynamic inputs

---------

Co-authored-by: Priti Sambandam <psamband@microsoft.com>

* Fix theme for colorizer

* Update snapshot tests

---------

Co-authored-by: Eric Wu <95886809+Eric-B-Wu@users.noreply.github.com>
Co-authored-by: Travis Harris <travisharris@microsoft.com>
Co-authored-by: preetriti1 <48265693+preetriti1@users.noreply.github.com>
Co-authored-by: Priti Sambandam <psamband@microsoft.com>
Co-authored-by: Shuktika Jain <shj@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Designer saving default values for Initiate Variables as strings
2 participants