Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(designer): Updates to Custom Code (boilerplate, host.json, optimizations) #4690

Merged
merged 6 commits into from Apr 24, 2024

Conversation

Eric-B-Wu
Copy link
Contributor

This is adding adding a few new features/fixes as part of custom code namely:

  1. Adding boiler plate code for powershell and c sharp that will be set on initialization
  2. Fixing Token picker outputs for powershell and c sharp
  3. Adding Host.json changes needed for powershell
  4. Cleaning up some code

@Eric-B-Wu Eric-B-Wu added the BREAKING Includes breaking change for npm packages label Apr 24, 2024
@hartra344
Copy link
Contributor

Can you add an explanation for how this is breaking? Will this require changes for PA/ICM?

@Eric-B-Wu
Copy link
Contributor Author

Can you add an explanation for how this is breaking? Will this require changes for PA/ICM?

Oh I guess its only breaking for us because we'll be the only one that'll require changes. There were some functions that were used previously in our Portal repo that were removed. I'll need to basically update the DesignerEditr with he changes I've made here in standalone.

@Eric-B-Wu Eric-B-Wu merged commit e911432 into main Apr 24, 2024
13 checks passed
@Eric-B-Wu Eric-B-Wu deleted the eric/moreCustomCode branch April 24, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING Includes breaking change for npm packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants