Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Designer): Revert - Updated HTML Editor to support newline characters #4807

Merged
merged 3 commits into from May 8, 2024
Merged

fix(Designer): Revert - Updated HTML Editor to support newline characters #4807

merged 3 commits into from May 8, 2024

Conversation

Eric-B-Wu
Copy link
Contributor

reverting: #4635

Pre revert:
prerevert

Post revert:

revert

@Eric-B-Wu Eric-B-Wu mentioned this pull request May 8, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024

Code Coverage Report

Code Coverage

Package Base Coverage New Coverage Difference
lib.editor.base.utils 🔴 27.03% 🔴 29.92% 🟢 2.89%
lib.html.plugins.toolbar.helper 🔴 27.24% 🔴 27.85% 🟢 0.61%
Overall Coverage 🟢 20.79% 🟢 25.18% 🟢 4.39%

Minimum allowed coverage is 0%, this run produced 25.18%

@Eric-B-Wu Eric-B-Wu merged commit 4d2a984 into main May 8, 2024
12 checks passed
@Eric-B-Wu Eric-B-Wu deleted the eric/reverthtmlchanges branch May 8, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hartra344 hartra344 hartra344 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Eric-B-Wu @hartra344