Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for outer scope deployments using secure parameters #1475

Closed
BernieWhite opened this issue Jun 13, 2022 · 1 comment · Fixed by #1743
Closed

Check for outer scope deployments using secure parameters #1475

BernieWhite opened this issue Jun 13, 2022 · 1 comment · Fixed by #1743
Assignees
@ms-sambell
Labels
help wanted Extra attention is needed integration: defender-for-devops New feature or request for ARM Template Best Practice Analyzer rule: deployment Rule for Azure Resource Manager templates
Milestone
v1.22.0

Comments

@BernieWhite
Copy link
Collaborator

Rule request

Suggested rule change

Deployments using an outer scope should not use any secureObject or secureString parameters.

Applies to the following

The rule applies to the following:

  • Resource type: Microsoft.Resources/deployments

Additional context

TTK test
@BernieWhite BernieWhite added rule: deployment Rule for Azure Resource Manager templates help wanted Extra attention is needed integration: defender-for-devops New feature or request for ARM Template Best Practice Analyzer labels Jun 13, 2022
@ms-sambell ms-sambell self-assigned this Jun 13, 2022
@ms-sambell
Copy link
Contributor

Hey @BernieWhite,

Is this rule similar to : https://github.com/Azure/PSRule.Rules.Azure/blob/main/src/PSRule.Rules.Azure/rules/Azure.Deployment.Rule.ps1#L16

But checking for a rendered secureString|secureObject parameters?

@ms-sambell ms-sambell mentioned this issue Oct 3, 2022
Merged
11 tasks
@BernieWhite BernieWhite added this to the v1.22.0 milestone Nov 15, 2022
@BernieWhite BernieWhite mentioned this issue Nov 20, 2022
Merged
4 tasks
@BernieWhite BernieWhite mentioned this issue Nov 28, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ms-sambell ms-sambell

Labels
help wanted Extra attention is needed integration: defender-for-devops New feature or request for ARM Template Best Practice Analyzer rule: deployment Rule for Azure Resource Manager templates
Projects
None yet
Milestone
v1.22.0
Development

Successfully merging a pull request may close this issue.

New rule/deployment outer scope evaluation ms-sambell/PSRule.Rules.Azure
2 participants
@BernieWhite @ms-sambell