Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report]: AppGateway Request and Response buffers default in module #2404

Open
ramuvr opened this issue Oct 25, 2023 · 5 comments
Open
Assignees
Labels
Class: Resource Module 📦 This is a resource module Needs: Module Owner 📣 This module needs an owner to develop or maintain it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue

Comments

@ramuvr
Copy link

ramuvr commented Oct 25, 2023

Describe the bug

As per MS Doc, the value for buffers should default to true.

"By default, both Request and Response buffers are enabled on your Application Gateway resource but you can choose to configure them separately."

To reproduce

Access file modules\network\application-gateway\main.bicep and see code snippet values

Code snippet

@description('Optional. Enable request buffering.')
param enableRequestBuffering bool = false

@description('Optional. Enable response buffering.')
param enableResponseBuffering bool = false

Relevant log output

No response

@ramuvr ramuvr changed the title [Bug Report]: [Bug Report]: AppGateway Request and Response buffers default in module Oct 25, 2023
@AlexanderSehr
Copy link
Contributor

Hey @ramuvr , thank you for opening this back and thank you for providing the docs reference.
If I understand you correctly, all this takes is changing both buffering switches to true to align with the best-practices? If so, we can certainly do that.

@ramuvr
Copy link
Author

ramuvr commented Oct 28, 2023

Hey @ramuvr , thank you for opening this back and thank you for providing the docs reference. If I understand you correctly, all this takes is changing both buffering switches to true to align with the best-practices? If so, we can certainly do that.

Yes, @AlexanderSehr that's my understanding. Deployed couple of appGateways recently without the attribute and noticed they were false but our template had default value so what-if was reporting I was going to change them.

@AlexanderSehr AlexanderSehr self-assigned this Oct 28, 2023
@AlexanderSehr AlexanderSehr transferred this issue from Azure/ResourceModules Jun 15, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Jun 15, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@AlexanderSehr
Copy link
Contributor

Hey @ilhaan,
I just migrated this issue over from CARML. Please take a look and triage if still relevant :)

@AlexanderSehr AlexanderSehr added Needs: Module Owner 📣 This module needs an owner to develop or maintain it Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Jun 15, 2024
@ilhaan
Copy link
Member

ilhaan commented Jun 19, 2024

@AlexanderSehr I will take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Needs: Module Owner 📣 This module needs an owner to develop or maintain it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
Status: Needs: Triage
Status: Low priority
Development

No branches or pull requests

3 participants