Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

[Kubernetes] Allocatable.pods sets to 110 regardless of agent VM size #416

Closed
ams0 opened this issue Mar 17, 2017 · 3 comments
Closed

[Kubernetes] Allocatable.pods sets to 110 regardless of agent VM size #416

ams0 opened this issue Mar 17, 2017 · 3 comments

Comments

@ams0
Copy link

ams0 commented Mar 17, 2017

For ACS- and RP- created kubernetes clusters, agent nodes are created with the default value for allocatable pods of 110. For large VM sizes, that could be not desirable. A better way would be to calculate an ideal value for different VM sizes, and add the --max-pods flag to parts/kuberneteskubelet.service. This could be part of the OrchestratorProfile.KubernetesConfig options.

@colemickens
Copy link
Contributor

I'd rather it be part of the agent pool profile, since that's where SKU is set. We could allow the user to override a default of 110 rather than try to do some magical calculation. And I'd argue that if there were a magic calculation, it would be based on mem/cpu and live in kubelet itself rather than here.

@ofiliz
Copy link
Contributor

ofiliz commented Apr 5, 2017

Note this has implications on the number of pod IP addresses that need to be assigned to the network interface when VNET-integration is enabled.

@CecileRobertMichon
Copy link
Contributor

fixed via #1854, #1954 and #2618.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants