Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add draft info languages #80

Merged
merged 21 commits into from Jan 9, 2023

Conversation

davidgamero
Copy link
Contributor

Description

Integrate draft info command output as source for draft languages and example versions in the 'draft a dockerfile' command

Feature # (details)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s).

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

src/commands/runDraftTool/helper/languages.ts Outdated Show resolved Hide resolved
src/commands/runDraftTool/helper/languages.ts Outdated Show resolved Hide resolved
src/commands/runDraftTool/runDraftDockerfile.ts Outdated Show resolved Hide resolved
src/commands/runDraftTool/runDraftDockerfile.ts Outdated Show resolved Hide resolved
@davidgamero
Copy link
Contributor Author

after a conversation with @Tatsinnit we have determined that the cleanest way forward is to run the windows tests on a 64bit runner.
I see that there is an option for setting windows archive that we can use to get around the whole 32 bit issue since the runner isn't even a 32bit runner, it was just running the 32bit version of vscode for testing

@davidgamero davidgamero merged commit 29f830f into Azure:main Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants