New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade azuredisk csi driver to v1.28.3 #190

Merged

christinalau0 merged 16 commits into Azure:master from christinalau0:csi-driver-1.28.3

Oct 5, 2023

Contributor

christinalau0 commented Sep 30, 2023 •

edited

Loading

Reason for Change:

Upgrade azuredisk-csi-driver to v1.28.3 for k8s v1.27. Keep azuredisk-csi-driver v1.26.5 for k8s v1.26.
- Release notes: https://github.com/kubernetes-sigs/azuredisk-csi-driver/releases/tag/v1.28.3
- Upstream AKS uses azuredisk-csi-driver v1.28.3 for k8s v1.27 and azuredisk-csi-driver v1.26.5 for k8s v1.26.
- Restructured k8s_versions.go to allow for different azuredisk-csi-driver versions for different k8s versions.
Bump all components according to new v1.28.3 csi driver values
- Restructured k8s_versions.go to allow for different azuredisk-csi-driver component versions for different k8s versions.
Change addon yaml to match new v1.28.3 csi driver templates

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

No
Yes

If "Yes," did you notify that project's maintainers and provide attribution?

No
Yes

Requirements:

uses conventional commit messages
includes documentation
adds unit tests
tested upgrade from previous version

Notes:

christinalau0 added 6 commits

September 29, 2023 12:15


          upgrade azuredisk-csi-driver to v1.28.3

0cb70ec

    - Upstream AKS uses azuredisk-csi-driver v1.26.5 for k8s v1.26 and azuredisk-csi-driver v1.28.3 for k8s v1.27.
    - Upgrade azuredisk csi driver to v1.28.3
    - Upgrade all components according to new v1.28.3 csi driver values: https://github.com/kubernetes-sigs/azuredisk-csi-driver/blob/master/charts/v1.28.3/azuredisk-csi-driver/values.yaml


          update v1.28.3 csi driver template: csi-azuredisk-node-windows.yaml

10d6615

    - https://github.com/kubernetes-sigs/azuredisk-csi-driver/blob/master/charts/v1.26.6/azuredisk-csi-driver/templates/csi-azuredisk-node-windows.yaml
    - https://github.com/kubernetes-sigs/azuredisk-csi-driver/blob/master/charts/v1.28.3/azuredisk-csi-driver/templates/csi-azuredisk-node-windows.yaml


          update v1.28.3 csi driver template: csi-azuredisk-node.yaml

fe06af5

        - https://github.com/kubernetes-sigs/azuredisk-csi-driver/blob/master/charts/v1.26.6/azuredisk-csi-driver/templates/csi-azuredisk-node.yaml
        - https://github.com/kubernetes-sigs/azuredisk-csi-driver/blob/master/charts/v1.28.3/azuredisk-csi-driver/templates/csi-azuredisk-node.yaml


          update v1.28.3 csi driver template: csi-azuredisk-controller.yaml

780c932

        - https://github.com/kubernetes-sigs/azuredisk-csi-driver/blob/master/charts/v1.26.6/azuredisk-csi-driver/templates/csi-azuredisk-controller.yaml
        - https://github.com/kubernetes-sigs/azuredisk-csi-driver/blob/master/charts/v1.28.3/azuredisk-csi-driver/templates/csi-azuredisk-controller.yaml


          update v1.28.3 csi driver template: csi-snapshot-controller.yaml

413790a

- https://github.com/kubernetes-sigs/azuredisk-csi-driver/blob/master/charts/v1.26.6/azuredisk-csi-driver/templates/csi-snapshot-controller.yaml
- https://github.com/kubernetes-sigs/azuredisk-csi-driver/blob/master/charts/v1.28.3/azuredisk-csi-driver/templates/csi-snapshot-controller.yaml


          update v1.28.3 csi driver template: crd-csi-snapshot.yaml

cee0ed5

        - https://github.com/kubernetes-sigs/azuredisk-csi-driver/blob/master/charts/v1.26.6/azuredisk-csi-driver/templates/crd-csi-snapshot.yaml
        - https://github.com/kubernetes-sigs/azuredisk-csi-driver/blob/master/charts/v1.28.3/azuredisk-csi-driver/templates/crd-csi-snapshot.yaml

christinalau0 requested a review from jadarsie as a code owner

September 30, 2023 00:43

Contributor Author

christinalau0 commented Sep 30, 2023

/azp run

azure-pipelines bot commented Sep 30, 2023

Azure Pipelines successfully started running 1 pipeline(s).

christinalau0 commented

View reviewed changes

docs/topics/azure-stack.md Show resolved Hide resolved


          Update generated template

56f6fc8

Contributor Author

christinalau0 commented Sep 30, 2023

/azp run

azure-pipelines bot commented Sep 30, 2023

Azure Pipelines successfully started running 1 pipeline(s).


          Fix syntax

9b25bae

Contributor Author

christinalau0 commented Sep 30, 2023

/azp run

azure-pipelines bot commented Sep 30, 2023

Azure Pipelines successfully started running 1 pipeline(s).

christinalau0 added 2 commits

October 3, 2023 16:31


          Fix k8s_versions_test

7315a92


          Change addon template based on version

4c5f2e5

Contributor Author

christinalau0 commented Oct 4, 2023

/azp run

azure-pipelines bot commented Oct 4, 2023

Azure Pipelines successfully started running 1 pipeline(s).


          Fix lint

459206a

Contributor Author

christinalau0 commented Oct 4, 2023

/azp run

azure-pipelines bot commented Oct 4, 2023

Azure Pipelines successfully started running 1 pipeline(s).


          Fix GCR for unit tests

45da9eb

Contributor Author

christinalau0 commented Oct 4, 2023

/azp run

azure-pipelines bot commented Oct 4, 2023

Azure Pipelines successfully started running 1 pipeline(s).

Member

jadarsie commented Oct 4, 2023

Would it be a good idea to set TEST_PVC in e2e-job-template.yaml? Not sure if we had a good reason to skip this in the past.

christinalau0 added 3 commits

October 4, 2023 15:04


          Update documentation for Windows HostProcess containers

11b8696


          Test PVC by default

db74df8


          Add IsAzureDiskCSIDriverVersionGe

3c44032

Contributor Author

christinalau0 commented Oct 4, 2023

/azp run

azure-pipelines bot commented Oct 4, 2023

Azure Pipelines successfully started running 1 pipeline(s).


          Revert "Add IsAzureDiskCSIDriverVersionGe"

35ae088

This reverts commit 3c44032.

Contributor Author

christinalau0 commented Oct 5, 2023

/azp run

azure-pipelines bot commented Oct 5, 2023

Azure Pipelines successfully started running 1 pipeline(s).

jadarsie approved these changes

View reviewed changes

christinalau0 merged commit 27a359a into Azure:master

6 checks passed

christinalau0 deleted the csi-driver-1.28.3 branch

October 5, 2023 17:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment