This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
chore(CIS): Ensure password creation requirements are configured #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1035 +/- ##
==========================================
+ Coverage 74.33% 74.33% +<.01%
==========================================
Files 131 131
Lines 18259 18260 +1
==========================================
+ Hits 13573 13574 +1
Misses 3905 3905
Partials 781 781 |
CecileRobertMichon
changed the title
CecileRobertMichon
force-pushed
the
cis-5.3.1
branch
from
6a7d007
to
c3a0886
Compare
|
/hold |
CecileRobertMichon
force-pushed
the
cis-5.3.1
branch
from
c3a0886
to
94a15fd
Compare
|
/hold cancel |
CecileRobertMichon
force-pushed
the
cis-5.3.1
branch
from
36d4299
to
48ac49c
Compare
mboersma
added
the
needs-rebase
CecileRobertMichon
force-pushed
the
cis-5.3.1
branch
from
c2f48bb
to
8c07811
Compare
CecileRobertMichon
removed
the
needs-rebase
CecileRobertMichon
force-pushed
the
cis-5.3.1
branch
from
5ba7d28
to
7559f3d
Compare
|
/hold cancel validated E2E on Ubuntu distro: |
fix indent add sshd verification to e2e fix test expectations add pwquality file contents fix file name rebase errata use Packer to write file to disk add package to release notes move files after package install add -q option to apt-get install add todo e2e add todo e2e script move file to /etc/security/pwquality.conf.d/CIS.conf move file copy lines to function add --force-confold option add pwscore test fix dash extra dash remove new packages from e2e not on vhd yet pwscore needs sudo fix validation script remove log line
CecileRobertMichon
force-pushed
the
cis-5.3.1
branch
from
baed9f3
to
f9557e4
Compare
mboersma
reviewed
Apr 18, 2019
| @@ -40,7 +40,7 @@ installDeps() { | |||
| retrycmd_if_failure 60 5 10 dpkg -i /tmp/packages-microsoft-prod.deb || exit $ERR_MS_PROD_DEB_PKG_ADD_FAIL | |||
| apt_get_update || exit $ERR_APT_UPDATE_TIMEOUT | |||
| apt_get_dist_upgrade || exit $ERR_APT_DIST_UPGRADE_TIMEOUT | |||
| apt_get_install 30 1 600 apt-transport-https blobfuse ca-certificates ceph-common cgroup-lite cifs-utils conntrack ebtables ethtool fuse git glusterfs-client init-system-helpers iproute2 ipset iptables jq mount nfs-common pigz socat util-linux xz-utils zip htop iotop iftop sysstat || exit $ERR_APT_INSTALL_TIMEOUT | |||
| apt_get_install 30 1 600 apt-transport-https blobfuse ca-certificates ceph-common cgroup-lite cifs-utils conntrack cracklib-runtime ebtables ethtool fuse git glusterfs-client init-system-helpers iproute2 ipset iptables jq libpam-pwquality libpwquality-tools mount nfs-common pigz socat util-linux xz-utils zip htop iotop iftop sysstat || exit $ERR_APT_INSTALL_TIMEOUT | |||
There was a problem hiding this comment.
Thank you for alphabetizing, although I see some miscreants at the end of the list.
There was a problem hiding this comment.
I have a python one-liner in a PR thread somewhere :)
There was a problem hiding this comment.
I'll fix the order for the other packages in a separate PR if that's okay with you so I don't have to rebase another time.
There was a problem hiding this comment.
Yes, of course. I was just noticing it.
|
lgtm pending "ubuntu" distro test |
|
Ubuntu distro tested, see above comment for output. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
CIS 5.3.1: Ensure password creation requirements are configured.
This will enforce stricter password rules, >= 14 characters with at least 1 uppercase, 1 lowercase, 1 special char, 1 digit and no recognized dictionary words.
Issue Fixed:
#1016
Requirements:
Notes: