Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

refactor: remove engine pkg custom script unnecessary functions #1036

Merged
merged 1 commit into from Apr 12, 2019

Conversation

CecileRobertMichon
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon commented Apr 11, 2019

Reason for Change:

Removes lines of code. Custom data no longer uses GetKubernetesB64 functions anymore so they do not need to be exported now that they are only used by the engine package.

Issue Fixed:

Requirements:

Notes:

@jackfrancis
Copy link
Member

lgtm

@codecov
Copy link

codecov bot commented Apr 11, 2019

Codecov Report

Merging #1036 into master will increase coverage by 0.07%.
The diff coverage is 95.65%.

@@            Coverage Diff             @@
##           master    #1036      +/-   ##
==========================================
+ Coverage   74.53%   74.61%   +0.07%     
==========================================
  Files         131      130       -1     
  Lines       17973    17897      -76     
==========================================
- Hits        13397    13353      -44     
+ Misses       3827     3795      -32     
  Partials      749      749

@jackfrancis
Copy link
Member

/lgtm

@acs-bot acs-bot added the lgtm label Apr 12, 2019
@acs-bot acs-bot merged commit 51f30a0 into Azure:master Apr 12, 2019
@acs-bot
Copy link

acs-bot commented Apr 12, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CecileRobertMichon,jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants