Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: fix generate command for Azure Stack #1038

Merged
merged 1 commit into from Apr 12, 2019
Merged

Conversation

honcao
Copy link
Member

@honcao honcao commented Apr 12, 2019

Reason for Change:

fix generate command for Azure Stack

Issue Fixed:

Requirements:

Notes:

@acs-bot acs-bot added the size/M label Apr 12, 2019
@honcao
Copy link
Member Author

honcao commented Apr 12, 2019

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Apr 12, 2019

Codecov Report

Merging #1038 into master will decrease coverage by <.01%.
The diff coverage is 35.71%.

@@            Coverage Diff            @@
##           master   #1038      +/-   ##
=========================================
- Coverage   74.61%   74.6%   -0.01%     
=========================================
  Files         130     130              
  Lines       17897   17905       +8     
=========================================
+ Hits        13353   13358       +5     
- Misses       3795    3797       +2     
- Partials      749     750       +1

@mboersma
Copy link
Member

lgtm

Thanks @honcao! Refs #1032.

@mboersma
Copy link
Member

Let's get this into the next patch release.

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Apr 12, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, honcao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mboersma mboersma merged commit 1859947 into Azure:master Apr 12, 2019
mboersma pushed a commit to mboersma/aks-engine that referenced this pull request Apr 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants