This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
feat: support VMSS agent nodes with public IP. #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunSun17
changed the title
JunSun17
force-pushed
the
jusu-public-node
branch
2 times, most recently
from
93d3bc8
to
62a70ef
Compare
Codecov Report
@@ Coverage Diff @@
## master #1087 +/- ##
==========================================
+ Coverage 74.33% 74.35% +0.01%
==========================================
Files 131 131
Lines 18260 18274 +14
==========================================
+ Hits 13574 13588 +14
Misses 3905 3905
Partials 781 781 |
JunSun17
force-pushed
the
jusu-public-node
branch
from
62a70ef
to
e611e3a
Compare
|
lgtm |
|
/lgtm for the label |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, JunSun17 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jackfrancis
pushed a commit
to jackfrancis/aks-engine
that referenced
this pull request
Apr 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Support VMSS agent nodes with public IP.
Issue Fixed:
Fixes #130
Requirements:
Notes:
This feature is controlled by EnableVMSSNodePublicIP flag in agent pool. When activated, it will create a public IP for each VMSS nodes.
A reference doc is here: https://docs.microsoft.com/en-us/azure/virtual-machine-scale-sets/virtual-machine-scale-sets-networking#creating-a-scale-set-with-public-ip-per-virtual-machine