feat: enable WindowsProfile in defaults enforcement code flow #1103
feat: enable WindowsProfile in defaults enforcement code flow #1103
Conversation
// setWindowsProfileDefaults sets default WindowsProfile values | ||
func (p *Properties) setWindowsProfileDefaults(isUpgrade, isScale bool) { | ||
windowsProfile := p.WindowsProfile | ||
if !isUpgrade && !isScale { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will not apply any defaults enforcement for pre-existing clusters.
/LGTM |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, xizhamsft The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #1103 +/- ##
==========================================
+ Coverage 74.35% 74.39% +0.04%
==========================================
Files 131 131
Lines 18274 18287 +13
==========================================
+ Hits 13588 13605 +17
+ Misses 3905 3903 -2
+ Partials 781 779 -2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm pending Windows E2E tests
@PatrickLang and @craiglpeters should sign off on this change, as it includes a change to the default Windows image version string we use to build Windows node vms. |
Welp. So much for this improving Windows 1.14 IIS flakiness. @PatrickLang is this the image we expect from the
|
Reason for Change:
Adds
WindowsProfile
into the standard defaults enforcement code flow. We retain the existing ARM parameters defaults to ensure back-compat defaults enforcement for pre-existing clusters.This PR delivers the following opinionated defaults, which are subject to review:
Previous defaults were:
WindowsPublisher = "MicrosoftWindowsServer" (unchanged in this PR)
WindowsOffer = "WindowsServerSemiAnnual" (unchanged in this PR)
WindowsSku = "Datacenter-Core-1809-with-Containers-smalldisk" (unchanged in this PR)
WindowsVersion = "latest" (this PR changes this value to an opinonated, dated version)
Issue Fixed:
Requirements:
Notes: