chore: disable --pod-max-pids by default #1126
Conversation
| @@ -269,7 +269,7 @@ Below is a list of kubelet options that aks-engine will configure by default: | |||
| | "--image-gc-low-threshold" | "850" | | |||
| | "--non-masquerade-cidr" | "10.0.0.0/8" | | |||
| | "--azure-container-registry-config" | "/etc/kubernetes/azure.json" | | |||
| | "--pod-max-pids" | "100" (need to activate the feature in --feature-gates=SupportPodPidsLimit=true) | | |||
| | "--pod-max-pids" | "-1" (need to activate the feature in --feature-gates=SupportPodPidsLimit=true) | | |||
There was a problem hiding this comment.
We should track an issue to make this a sensible default as a follow up item (-1 doesn't really make sense as a default value).
There was a problem hiding this comment.
I agree, but that's what the work-in-progress docs say: kubernetes/website#13806
There was a problem hiding this comment.
I also asked for clarification on what 0 means. If it disables the feature, then I think we may actually want 0 instead of -1 (node enforceable limit) if we don't set a node enforceable limit today.
Codecov Report
@@ Coverage Diff @@
## master #1126 +/- ##
======================================
Coverage 74.4% 74.4%
======================================
Files 131 131
Lines 18286 18286
======================================
Hits 13606 13606
Misses 3901 3901
Partials 779 779 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
# Conflicts: # pkg/engine/testdata/key-vault-certs/kubernetes.json
|
How do I get this change applied to my clusters? |
|
@Sahasrara upgrading your cluster ( |
Reason for Change:
--pod-max-pidsconfiguration became enabled without --feature-gates opt-in starting in 1.14. Because there are lots of valid workflows that fork a bunch of processes, we want to be careful about setting an upper bound by default. This PR disables the upper limit to be permissive for such workloads.Issue Fixed:
Fixes #1055
Requirements:
Notes: