This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
chore: clean up containerd and cc-runtime when unused #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -17,7 +17,7 @@ removeEtcd() { | |||
| } | |||
|
|
|||
| removeMoby() { | |||
| sudo apt-get purge -y moby-engine moby-cli | |||
| apt-get purge -y moby-engine moby-cli | |||
There was a problem hiding this comment.
this is already running as root, no need for sudo
Codecov Report
@@ Coverage Diff @@
## master #1129 +/- ##
======================================
Coverage 74.4% 74.4%
======================================
Files 131 131
Lines 18283 18283
======================================
Hits 13603 13603
Misses 3901 3901
Partials 779 779 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Remove the installs for containerd and clear containers during CSE when that cluster does not need them. These are pre-installed as part of the VHD.
Issue Fixed:
Fixes #1091
Requirements:
Notes: