Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: /etc/default/grub VHD enforcement #1131

Merged
merged 1 commit into from Apr 23, 2019

Conversation

jackfrancis
Copy link
Member

Reason for Change:

#1111 included a bug in VHD /etc/default/grub enforcement

Issue Fixed:

Follow up from #1111

Requirements:

Notes:

jackfrancis added a commit to jackfrancis/aks-engine that referenced this pull request Apr 23, 2019
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Apr 23, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CecileRobertMichon,jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Apr 23, 2019

Codecov Report

Merging #1131 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1131   +/-   ##
=======================================
  Coverage   74.39%   74.39%           
=======================================
  Files         131      131           
  Lines       18287    18287           
=======================================
  Hits        13604    13604           
  Misses       3902     3902           
  Partials      781      781

@jackfrancis jackfrancis merged commit ae3aecd into Azure:master Apr 23, 2019
@jackfrancis jackfrancis deleted the DEFAULT_GRUB_DEST-bogon branch April 23, 2019 21:13
@CecileRobertMichon CecileRobertMichon moved this from Done to Won't do in CIS spike - Spring 2019 Aug 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants