Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fix: clean generated and unit test helper files #1151

Merged
merged 1 commit into from Apr 25, 2019

Conversation

mboersma
Copy link
Member

Reason for Change:

make clean by tradition should clean up all generated and temporary files. This adds some droppings that were missed.

Issue Fixed:

Requirements:

Notes:

@jackfrancis
Copy link
Member

/lgtm

@acs-bot
Copy link

acs-bot commented Apr 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mboersma
Copy link
Member Author

mboersma commented Apr 25, 2019

/hold until #1088 is merged, since that will have us check in the generated go files intentionally.

@codecov
Copy link

codecov bot commented Apr 25, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@5f86d3d). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1151   +/-   ##
=========================================
  Coverage          ?   74.43%           
=========================================
  Files             ?      131           
  Lines             ?    18317           
  Branches          ?        0           
=========================================
  Hits              ?    13634           
  Misses            ?     3902           
  Partials          ?      781

@mboersma
Copy link
Member Author

/hold cancel

@acs-bot acs-bot merged commit 7136d80 into Azure:master Apr 25, 2019
@mboersma mboersma deleted the make-it-cleaner branch June 21, 2019 19:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants