style: use 'true' instead of '[ 1 ]' in shell loops

[mboersma]

Reason for Change:

Enforces a more readable bash syntax for infinite loops. See https://github.com/koalaman/shellcheck/wiki/SC2161

Issue Fixed:

Refs #953

Requirements:

• uses conventional commit messages
• includes documentation
• adds unit tests
• tested upgrade from previous version

Notes:

[CecileRobertMichon]

/lgtm

[acs-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [CecileRobertMichon,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Merging #1154 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1154   +/-   ##
=======================================
  Coverage   74.87%   74.87%           
=======================================
  Files         131      131           
  Lines       18428    18428           
=======================================
  Hits        13798    13798           
  Misses       3837     3837           
  Partials      793      793

[jackfrancis]

lgtm