Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: update omsagent addon to use the latest version #1156

Merged
merged 20 commits into from May 1, 2019
Merged

chore: update omsagent addon to use the latest version #1156

merged 20 commits into from May 1, 2019

Conversation

rashmichandrashekar
Copy link
Contributor

Update omsagent addon to use the latest released version - ciprod04232019 and the corresponding yaml changes

@acs-bot acs-bot added the size/L label Apr 25, 2019
@rashmichandrashekar
Copy link
Contributor Author

/assign @jackfrancis

@CecileRobertMichon CecileRobertMichon changed the title Update omsagent addon to use the latest version chore: update omsagent addon to use the latest version Apr 26, 2019
@CecileRobertMichon
Copy link
Contributor

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #1156 into master will increase coverage by 0.15%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1156      +/-   ##
==========================================
+ Coverage   74.71%   74.86%   +0.15%     
==========================================
  Files         129      129              
  Lines       18386    18434      +48     
==========================================
+ Hits        13737    13801      +64     
+ Misses       3856     3840      -16     
  Partials      793      793

@jackfrancis
Copy link
Member

lgtm pending omsagent cluster configuration test (in-progress)

@jackfrancis
Copy link
Member

omsagent cluster config test failed against this PR:

Azure Container Cluster using the Kubernetes Orchestrator
/go/src/github.com/Azure/aks-engine/test/e2e/kubernetes/kubernetes_test.go:91
  regardless of agent pool type
  /go/src/github.com/Azure/aks-engine/test/e2e/kubernetes/kubernetes_test.go:92
    should have addons running [It]
    /go/src/github.com/Azure/aks-engine/test/e2e/kubernetes/kubernetes_test.go:467

    Expected error:
        <*errors.fundamental | 0xc000446ce0>: {
            msg: "Timeout exceeded (30m0s) while waiting for Pods (omsagent) to become ready in namespace (kube-system), got 0 of 6 required successful pods ready results",
            stack: [0x9c6ad4, 0x45e941],
        }
        Timeout exceeded (30m0s) while waiting for Pods (omsagent) to become ready in namespace (kube-system), got 0 of 6 required successful pods ready results
    not to have occurred

    /go/src/github.com/Azure/aks-engine/test/e2e/kubernetes/kubernetes_test.go:485

@jackfrancis
Copy link
Member

/hold

@rashmichandrashekar
Copy link
Contributor Author

@jackfrancis - I have updated the PR for this test fix. Please run the tests again and this should pass now.

@jackfrancis
Copy link
Member

/lgtm

@acs-bot acs-bot added the lgtm label May 1, 2019
@jackfrancis
Copy link
Member

/azp run pr-e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@acs-bot
Copy link

acs-bot commented May 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, rashmichandrashekar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@CecileRobertMichon
Copy link
Contributor

/hold cancel

@acs-bot acs-bot merged commit 5baff31 into Azure:master May 1, 2019
CecileRobertMichon pushed a commit that referenced this pull request May 2, 2019
* updating omsagent to latest release version

* updates for latest omsagent yaml

* Fix for container monitoring addon

* doc update

* example for container-monitoring addon

* doc updates

* add instuctions to disable monitoring

* fixes for pr feedback

* pr feedback

* changes for new omsagent version

* updating to latest version

* undoing local changes

* undoing local changes

* undoing local changes

* fixing memory lmit
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants