Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

ci: exclude some test files from coverage report #1160

Merged
merged 1 commit into from Apr 26, 2019

Conversation

mboersma
Copy link
Member

Reason for Change:

Adds some mock implementations and test code to codecov's exclusion list.

Issue Fixed:

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #1160 into master will decrease coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1160      +/-   ##
==========================================
- Coverage   74.91%   74.73%   -0.18%     
==========================================
  Files         131      129       -2     
  Lines       18458    18325     -133     
==========================================
- Hits        13828    13696     -132     
+ Misses       3837     3836       -1     
  Partials      793      793

@CecileRobertMichon
Copy link
Contributor

-0.18%

?? 🤔

@mboersma
Copy link
Member Author

mboersma commented Apr 26, 2019

I think we were actually benefitting from including these files in the coverage report. Since they are the tests, their "test coverage" was probably close to 100%.

@jackfrancis
Copy link
Member

/lgtm

@acs-bot acs-bot added the lgtm label Apr 26, 2019
@jackfrancis jackfrancis merged commit 8a3888f into Azure:master Apr 26, 2019
@acs-bot
Copy link

acs-bot commented Apr 26, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mboersma mboersma deleted the tweak-coverage branch April 30, 2019 16:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants