This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
fix: delete vm if node is not ready after upgrade. #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1173 +/- ##
==========================================
- Coverage 74.71% 74.69% -0.02%
==========================================
Files 129 129
Lines 18387 18391 +4
==========================================
Hits 13738 13738
- Misses 3856 3860 +4
Partials 793 793 |
|
lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, JunSun17 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
When upgrade, if the newly added node is not ready, it will fail the upgrade attempt but that node will be kept. However, in the next upgrade attempt, another working node will be deleted, which ends up with a cluster with less than specified number of working nodes.
Here the fix is to remove the newly added node if it reports not ready.
Issue Fixed:
Requirements:
Notes: